Escaping translations #3032
Merged
Escaping translations #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
added
Status:Needs-Review
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
force-pushed
the
tech-debt/escaping-translations
branch
from
9c9e156
to
3fc541c
Compare
|
Docs about escaping here - owncloud/owncloud-design-system#639 |
PVince81
reviewed
Feb 13, 2020
| @@ -258,7 +258,7 @@ export default { | |||
| }, | |||
| noResharePermsMessage () { | |||
| const translated = this.$gettext('You don\'t have permission to share this %{type}.') | |||
| return this.$gettextInterpolate(translated, { type: this.highlightedFile.type }) | |||
| return this.$gettextInterpolate(translated, { type: this.highlightedFile.type }, false) | |||
There was a problem hiding this comment.
does it hurt keeping "true" here ? just wondering
There was a problem hiding this comment.
The only values we are getting here are "file" and "folder" so don't see much value in keeping it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't escape translations in case they contain resource name or user name. Escape everything else.
How Has This Been Tested?
Types of changes
Checklist: