Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change share icons to collaborators #3116

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

PVince81
Copy link
Contributor

Description

Adjust icon in files app navigation bar and also in the file actions
dropdown to use the group icon.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/3858

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

LukasHirt
LukasHirt previously approved these changes Feb 28, 2020
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 28, 2020

from @pmaier1:

  • Also need to take care of the icons on the "Shared with..." empty folder icons

@PVince81 PVince81 dismissed LukasHirt’s stale review February 28, 2020 11:01

Forgot some missing thing, see comment below.

@PVince81
Copy link
Contributor Author

also changed icon for empty folder in shared file lists

@LukasHirt please review again :-)

@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2020

rebased, and now separated the changelog into a new item as the other part was released already

changelog/unreleased/3116 Outdated Show resolved Hide resolved
Adjust icon in files app navigation bar and also in the file actions
dropdown to use the group icon.
@PVince81 PVince81 merged commit 308736f into master Mar 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-nav-share-icons branch March 2, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants