Sort collaborators column, deduplicate public #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Mar 11, 2020
LukasHirt
reviewed
Mar 11, 2020
LukasHirt
reviewed
Mar 11, 2020
PVince81
force-pushed
the
fix-duplicate-public-collaborator
branch
from
539434f
to
90fb7ee
Compare
Sort the collaborators by share type (user, group, link, remote) and by display name. Deduplicate the public link entry so it only appears once in the column.
PVince81
force-pushed
the
fix-duplicate-public-collaborator
branch
from
90fb7ee
to
1a372d4
Compare
LukasHirt
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The collaborators appears a the column in the "shared with others" section are now sorted: first by share type (user, group, remote, link) and then by display name using natural sort.
Additionally, if there is more than one public link for the resource, the text "Public" only appears once in the collaborators column.
Related Issue
Fixes #3137
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks:
None