[full-ci] Fix inheritance of share permissions on reshares #7015
Conversation
|
Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/25764/62/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIResharing1-reshareUsers_feature-L219.pngwebUIResharing1-reshareUsers_feature-L237.png |
JammingBen
changed the title
JammingBen
force-pushed
the
fix-share-perm-inheritance
branch
from
dc23aa2
to
ca0a88a
Compare
JammingBen
force-pushed
the
fix-share-perm-inheritance
branch
from
ca0a88a
to
84c521e
Compare
packages/web-app-files/src/components/SideBar/Shares/Collaborators/RoleDropdown.vue
Outdated
Show resolved
Hide resolved
|
I can't find out why the 2 tests in https://drone.owncloud.com/owncloud/web/25760/62/15 keep failing. I tried to reproduce the steps several times on my local machine, but it always behaves correctly. Unfortunately, I can't get these 2 tests to run locally... @individual-it Maybe your team could have a look if the time permits? |
| @issue-5461 | ||
| Scenario: User is not allowed to reshare a file/folder with the higher permissions | ||
| Given user "Brian" has shared folder "simple-folder" with user "Alice" with "read, share, delete" permissions in the server | ||
| And user "Alice" has accepted the share "Shares/simple-folder" offered by user "Brian" in the server | ||
| And user "Alice" has logged in using the webUI | ||
| When the user opens folder "Shares" using the webUI | ||
| And the user shares folder "simple-folder" with user "Carol King" as "Custom permissions" with permissions "share, delete, update" using the webUI | ||
| Then the error message with header "Error while sharing." should be displayed on the webUI | ||
| And as "Carol" folder "Shares/simple-folder" should not exist in the server | ||
| And user "Carol" should not have received any shares in the server |
There was a problem hiding this comment.
why deleting this test? is the resharer now allowed to increase the permissions or is the test not applicable at all?
There was a problem hiding this comment.
We deleted the test because the tested behavior (selecting an invalid role shows an error) changed completely. We want to write a new e2e test to check the new behavior (an invalid role isn't even showing) in the future.
There was a problem hiding this comment.
Ah cool, so deleting these tests is not a lost because they never passed and never would.
CC @ScharfViktor is this resharing behavior on your list to test in e2e or do we need a new issue to make sure we don't forget to write the e2e tests?
There was a problem hiding this comment.
I created issue, not to forget it. #7041
|
Kudos, SonarCloud Quality Gate passed! |
Description
We've fixed a bug where the permissions of a share were not inherited when trying to reshare a resource. We've also disabled the role-select-dropdown if only one role is available for sharing.
Related Issue
Types of changes