Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9353 9354 button styling #9394

Merged
merged 5 commits into from
Jul 13, 2023
Merged

9353 9354 button styling #9394

merged 5 commits into from
Jul 13, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Jul 12, 2023

Description

Button styling has been made more consistent among various types and styles (success, warning etc and filled, outline on hover etc)

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

JammingBen
JammingBen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM code-wise as well as in the UI. I'd like to spawn @tbsbdr for a final approval for the UI 🙂

@JammingBen JammingBen requested a review from tbsbdr July 12, 2023 10:00
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tbsbdr
tbsbdr approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah 😍 nice improvement, thank you!

@grimmoc grimmoc marked this pull request as ready for review July 13, 2023 09:40
@grimmoc grimmoc merged commit 054ea57 into master Jul 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the 9353-9354-button-styling branch July 13, 2023 09:40
This was referenced Jul 13, 2023
Closed
Closed
@JammingBen JammingBen mentioned this pull request Jul 21, 2023
Merged
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@tbsbdr tbsbdr tbsbdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grimmoc @tbsbdr @JammingBen