[full-ci] Show local loading spinner in sharing button #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
JammingBen
requested changes
Jul 17, 2023
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
Outdated
Show resolved
Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
Outdated
Show resolved
Hide resolved
lookacat
changed the title
JammingBen
reviewed
Jul 18, 2023
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
Outdated
Show resolved
Hide resolved
|
done, now its outlined passive button on save |
|
SonarCloud Quality Gate failed.
|
JammingBen
approved these changes
Jul 18, 2023
AlexAndBear
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Add spinner / loading prop to oc-button * Add delayed spinner, set min-width * Add changelog, increase spinner size, cleanup code * Update snapshots (because of one v-if change in oc-button) * Address PR issues * Replace min-width with padding * Fix infinite loading / missing unref * Update snapshots * Address PR issues improve button look
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add spinner / loading prop to oc-button * Add delayed spinner, set min-width * Add changelog, increase spinner size, cleanup code * Update snapshots (because of one v-if change in oc-button) * Address PR issues * Replace min-width with padding * Fix infinite loading / missing unref * Update snapshots * Address PR issues improve button look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added a loading spinner to the share button in the sharing panel
to indicate that its still processing if action takes longer.
See #9425
Related Issue
Types of changes
Checklist: