Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "republish on reconnect" preference #1273

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Conversation

growse
Copy link
Collaborator

@growse growse commented Aug 22, 2022

#1178

Adds a preference to allow a user to indicate that a location + extended data should be re-published when MQTT is reconnected after a disconnect.

@growse growse added this to the 2.4.11 milestone Aug 22, 2022
@growse growse self-assigned this Aug 22, 2022
@growse growse added the integration-test-required PRs that need a full integration test suite before merging label Aug 22, 2022
@growse growse force-pushed the master branch 6 times, most recently from 442f735 to da44962 Compare September 18, 2022 13:01
@growse growse force-pushed the master branch 4 times, most recently from 1462038 to 6d76f1b Compare October 2, 2022 15:31
@growse growse added integration-test-required PRs that need a full integration test suite before merging and removed integration-test-required PRs that need a full integration test suite before merging labels Nov 4, 2022
@growse growse marked this pull request as ready for review November 4, 2022 09:57
@growse growse added integration-test-required PRs that need a full integration test suite before merging and removed integration-test-required PRs that need a full integration test suite before merging labels Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 45.98% // Head: 40.13% // Decreases project coverage by -5.84% ⚠️

Coverage data is based on head (2470963) compared to base (7931ce9).
Patch coverage: 53.84% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     45.98%   40.13%   -5.85%     
+ Complexity     1021      865     -156     
============================================
  Files           173      173              
  Lines          6776     6794      +18     
  Branches        693      694       +1     
============================================
- Hits           3116     2727     -389     
- Misses         3274     3698     +424     
+ Partials        386      369      -17     
Flag Coverage Δ
uitests 40.13% <53.84%> (-0.92%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...android/services/MessageProcessorEndpointMqtt.java 25.00% <28.57%> (-2.31%) ⬇️
.../java/org/owntracks/android/support/Preferences.kt 56.61% <58.82%> (-23.75%) ⬇️
...cks/android/model/messages/MessageWithCreatedAt.kt 100.00% <100.00%> (ø)
...g/owntracks/android/services/MessageProcessor.java 46.34% <100.00%> (-2.04%) ⬇️
.../java/org/owntracks/android/model/CommandAction.kt 0.00% <0.00%> (-100.00%) ⬇️
...rg/owntracks/android/model/messages/MessageCard.kt 0.00% <0.00%> (-100.00%) ⬇️
...ntracks/android/model/messages/MessageEncrypted.kt 0.00% <0.00%> (-100.00%) ⬇️
...tracks/android/ui/map/MapLayerBottomSheetDialog.kt 0.00% <0.00%> (-85.00%) ⬇️
...org/owntracks/android/model/messages/MessageCmd.kt 0.00% <0.00%> (-62.50%) ⬇️
...g/owntracks/android/model/messages/MessageClear.kt 0.00% <0.00%> (-60.00%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@growse growse merged commit 3af11f6 into master Nov 4, 2022
@growse growse deleted the republish-on-reconnect branch November 4, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-test-required PRs that need a full integration test suite before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant