perf: remove bounds check from IndexVec::push #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the Idx trait to enable bounds-check-free push operations by: - Adding MAX associated constant for the maximum valid index value - Adding unsafe from_usize_unchecked for unchecked index creation - Providing default impl of from_usize that validates bounds The push method now uses from_usize_unchecked since Vec's length is always valid - if it exceeded the index type's MAX, allocation would have failed long before reaching this point. This optimization eliminates unnecessary bounds checking in the hot path while maintaining safety through the type system. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes
IndexVec::pushby removing redundant bounds checking, improving performance in hot paths.Changes
Idxtrait withMAXconstant andunsafe fn from_usize_uncheckedpushto use unchecked index creationRationale
The bounds check in
pushis redundant because:isize::MAXbytes)Test Plan
🤖 Generated with Claude Code