feat: add const support to methods where possible #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `const` qualifiers to methods that can be evaluated at compile time, enabling their use in const contexts. Changes: - IndexVec: new(), as_vec(), as_mut_vec() - IndexSlice: as_raw_slice(), as_raw_slice_mut(), as_ptr(), as_mut_ptr(), len(), is_empty(), first(), last() - Macro-generated index types: index(), raw(), from_usize_unchecked(), from_raw_unchecked(), from_raw() (NonMaxU32 only) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Makes the following methods const in macro-generated index types: - new() - const constructor - from_raw() - const constructor from raw type - from_usize() - const constructor from usize - check_index() - const validation (uses panic! instead of __max_check_fail) This enables index types to be constructed in const contexts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
constqualifiers to methods that can be evaluated at compile time, enabling their use in const contexts.Changes
IndexVec
new()- const constructoras_vec()- const accessoras_mut_vec()- const mutable accessorIndexSlice
as_raw_slice()- const accessoras_raw_slice_mut()- const mutable accessoras_ptr()- const pointer accessoras_mut_ptr()- const mutable pointer accessorlen()- const lengthis_empty()- const checkfirst()- const first elementlast()- const last elementMacro-generated index types (define_index_type!)
index()- const index getterraw()- const raw value getterfrom_usize_unchecked()- const unchecked constructorfrom_raw_unchecked()- const unchecked raw constructorMacro-generated NonMax index types (define_nonmax_index_type!)
from_raw()- const constructorindex()- const index getterraw()- const raw value getterfrom_usize_unchecked()- const unchecked constructorfrom_raw_unchecked()- const unchecked raw constructorTesting
All existing tests pass.
🤖 Generated with Claude Code