Skip to content

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 14, 2025

No description provided.

Copy link

graphite-app bot commented Sep 14, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Sep 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (19c4868) to head (b76115b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   94.89%   94.92%   +0.02%     
==========================================
  Files          12       12              
  Lines        2882     2897      +15     
==========================================
+ Hits         2735     2750      +15     
  Misses        147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Sep 14, 2025

CodSpeed Performance Report

Merging #696 will not alter performance

Comparing mmap2 (b76115b) with main (19c4868)1

Summary

✅ 7 untouched
⏩ 2 skipped2

Footnotes

  1. No successful run was found on main (49cc7d0) during the generation of this report, so 19c4868 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen changed the title memmap2 perf: use memmap to speed up file reading Sep 15, 2025
@Boshen Boshen marked this pull request as ready for review September 15, 2025 11:02
@Boshen Boshen merged commit 5012c66 into main Sep 15, 2025
19 checks passed
@Boshen Boshen deleted the mmap2 branch September 15, 2025 11:14
@Boshen Boshen mentioned this pull request Sep 15, 2025
Boshen added a commit that referenced this pull request Sep 16, 2025
Boshen added a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant