-
-
Notifications
You must be signed in to change notification settings - Fork 32
refactor: split src/cache.rs into logical modules #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
13dd54e
to
fed4a57
Compare
fed4a57
to
fa74781
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 12 15 +3
Lines 2899 2899
=======================================
Hits 2745 2745
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #714 will not alter performanceComparing Summary
Footnotes
|
0d95a30
to
ded3cf7
Compare
a5f1c08
to
2284f0f
Compare
- Add back OnceCell import for yarn_pnp manifest storage - Fix pnp import to use external crate instead of crate::pnp - Ensures cargo check --all-features --all-targets passes - All 134 tests pass with yarn_pnp feature enabled
2284f0f
to
ec96dec
Compare
Summary
Split the large
src/cache.rs
file (2100+ lines) into focused, maintainable modules for better code organization and developer experience.Changes
Benefits
✅ Better maintainability - Each file has a clear, focused responsibility
✅ Improved code organization - Related functionality is logically grouped
✅ Easier navigation - Developers can quickly find specific cache components
✅ Reduced merge conflicts - Multiple developers can work on different cache components
✅ Same public API - No breaking changes for users of the library
Test Results
Test plan
cargo check
- compiles successfullycargo test
- all 149 tests pass🤖 Generated with Claude Code