perf: mark error path functions as #[cold] for better optimization #729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
#[cold]
attributes to error handling functions to improve performance by helping the compiler optimize for the common (non-error) path.Changes
#[cold]
attributes to error conversion functions insrc/error.rs
src/file_system.rs
- UTF-8 validation errorsrc/specifier.rs
- Empty specifier errorssrc/windows/mod.rs
- Unsupported path errorBenefits
The
#[cold]
attribute provides hints to the compiler that these functions are unlikely to be called, which enables:Test Plan
cargo check
passescargo clippy
shows no warnings🤖 Generated with Claude Code