Skip to content

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 3, 2025

Summary

  • Enhanced CI to run full pnpm test suite on wasm32-wasip1 and wasm32-unknown-unknown targets
  • Previously these jobs only ran cargo check, now they build NAPI bindings and run tests
  • Matches the existing wasi job pattern (wasm32-wasip1-threads)

Test plan

  • Updated CI workflow to add pnpm setup, build, and test steps for both targets
  • Verify CI passes with WebAssembly builds and tests

🤖 Generated with Claude Code

Previously these jobs only ran `cargo check`. Now they build the NAPI
bindings and run the full test suite for better coverage of WebAssembly
targets.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

graphite-app bot commented Oct 3, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Performance Report

Merging #745 will not alter performance

Comparing ci/test-wasm-targets (8795316) with main (4eb1051)

Summary

✅ 7 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (870f67e) to head (8795316).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   95.62%   95.09%   -0.54%     
==========================================
  Files          16       16              
  Lines        2951     2974      +23     
==========================================
+ Hits         2822     2828       +6     
- Misses        129      146      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen merged commit 1dbc88f into main Oct 4, 2025
18 checks passed
@Boshen Boshen deleted the ci/test-wasm-targets branch October 4, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants