Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ eslint-plugin-next #1929

Open
camc314 opened this issue Jan 7, 2024 · 4 comments
Open

☂️ eslint-plugin-next #1929

camc314 opened this issue Jan 7, 2024 · 4 comments

Comments

@camc314
Copy link
Collaborator

camc314 commented Jan 7, 2024 •
edited by github-actions bot
Loading

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for @next/eslint-plugin-next.

There are 21(+ 0 deprecated) rules.

  • 1/21 recommended rules are remaining as TODO
  • 0/0 not recommended rules are remaining as TODO
    • All done! 🎉

To get started, run the following command:

just new-nextjs-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 20, 🚫: 0 / total: 21
Status Name Docs
✨ nextjs/google-font-display https://nextjs.org/docs/messages/google-font-display
✨ nextjs/google-font-preconnect https://nextjs.org/docs/messages/google-font-preconnect
✨ nextjs/inline-script-id https://nextjs.org/docs/messages/inline-script-id
✨ nextjs/next-script-for-ga https://nextjs.org/docs/messages/next-script-for-ga
✨ nextjs/no-assign-module-variable https://nextjs.org/docs/messages/no-assign-module-variable
✨ nextjs/no-async-client-component https://nextjs.org/docs/messages/no-async-client-component
✨ nextjs/no-before-interactive-script-outside-document https://nextjs.org/docs/messages/no-before-interactive-script-outside-document
✨ nextjs/no-css-tags https://nextjs.org/docs/messages/no-css-tags
✨ nextjs/no-document-import-in-page https://nextjs.org/docs/messages/no-document-import-in-page
✨ nextjs/no-duplicate-head https://nextjs.org/docs/messages/no-duplicate-head
✨ nextjs/no-head-element https://nextjs.org/docs/messages/no-head-element
✨ nextjs/no-head-import-in-document https://nextjs.org/docs/messages/no-head-import-in-document
nextjs/no-html-link-for-pages https://nextjs.org/docs/messages/no-html-link-for-pages
✨ nextjs/no-img-element https://nextjs.org/docs/messages/no-img-element
✨ nextjs/no-page-custom-font https://nextjs.org/docs/messages/no-page-custom-font
✨ nextjs/no-script-component-in-head https://nextjs.org/docs/messages/no-script-component-in-head
✨ nextjs/no-styled-jsx-in-document https://nextjs.org/docs/messages/no-styled-jsx-in-document
✨ nextjs/no-sync-scripts https://nextjs.org/docs/messages/no-sync-scripts
✨ nextjs/no-title-in-document-head https://nextjs.org/docs/messages/no-title-in-document-head
✨ nextjs/no-typos
✨ nextjs/no-unwanted-polyfillio https://nextjs.org/docs/messages/no-unwanted-polyfillio

✨ = Implemented, 🚫 = No need to implement
@camc314 camc314 mentioned this issue Jan 7, 2024
Closed
@Boshen
Copy link
Member

Boshen commented Jan 8, 2024

Feels like we need a --next-plugin?

@IWANABETHATGUY IWANABETHATGUY changed the title ☔️ Linter: eslint plugin next ☔️ Linter: eslint plugin next.js Jan 8, 2024
@camc314
Copy link
Collaborator Author

camc314 commented Jan 8, 2024

Feels like we need a --next-plugin?

yeah that makes sense

@camc314 camc314 mentioned this issue Jan 8, 2024
Merged
mysteryven pushed a commit that referenced this issue Jan 9, 2024
@camc314
feat: nextjs plugin (#1948)
ac3b44b 
#1929 (comment)
@kaykdm
Copy link
Contributor

kaykdm commented Jan 10, 2024

no-typos

@camc314 Can I work on this?

@camc314
Copy link
Collaborator Author

camc314 commented Jan 10, 2024

no-typos

@camc314 Can I work on this?

yep, of course

This was referenced Jan 10, 2024
Merged
Merged
Merged
camc314 pushed a commit that referenced this issue Jan 13, 2024
@kaykdm
feat(linter): eslint-plugin-next: no-typos (#1978)
8f0f824 
Part of: #1929

Based on:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-typos.ts
camc314 added a commit that referenced this issue Jan 13, 2024
@kaykdm @camc314
feat(linter): eslint-plugin-next: no-head-element (#2006)
c70a065 
Part of: #1929

Based on:

- code: https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-head-element.ts
- test: https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-head-element.test.ts
- doc: https://nextjs.org/docs/messages/no-head-element

---------

Co-authored-by: Cameron Clark <cameron.clark@hey.com>
@camc314 camc314 mentioned this issue Jan 13, 2024
Open
camc314 added a commit that referenced this issue Jan 13, 2024
@kaykdm @camc314
feat(linter): eslint-plugin-next: no-document-import-in-page (#1997)
a356918 
Part of: #1929

Based on:
- https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-document-import-in-page.ts
-  https://nextjs.org/docs/messages/no-document-import-in-page

---------

Co-authored-by: Cameron <cameron.clark@hey.com>
@kaykdm kaykdm mentioned this issue Jan 21, 2024
Merged
Boshen pushed a commit that referenced this issue Jan 22, 2024
@kaykdm
feat(linter): support eslint config in nextjs eslint (#2107)
b160842 
related: #1929

Support Next.js eslint config settings.
- [custom settings
](https://nextjs.org/docs/app/building-your-application/configuring/eslint#custom-settings)
- also handle Next.js eslint rule name mapping

these are need before implementing [this
rule](https://nextjs.org/docs/messages/no-html-link-for-pages)
@Boshen Boshen changed the title ☔️ Linter: eslint plugin next.js ☂️ eslint-plugin-next Jan 26, 2024
@kaykdm kaykdm mentioned this issue Jan 29, 2024
Merged
Boshen pushed a commit that referenced this issue Jan 29, 2024
@kaykdm
feat(linter): implement @next/next/no-unwanted-polyfillio (#2197)
b694a6a 
implement @next/next/no-unwanted-polyfillio
Related issue: #1929

original implementation

- code:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-unwanted-polyfillio.ts
- test:
https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-unwanted-polyfillio.test.ts
- doc: https://nextjs.org/docs/messages/no-unwanted-polyfillio
@kaykdm kaykdm mentioned this issue Jan 29, 2024
Merged
Boshen pushed a commit that referenced this issue Jan 29, 2024
@kaykdm
feat(linter): implement @next/next/no-before-interactive-script-outsi… (
da3b305 
#2203)

…de-document

implement @next/next/no-before-interactive-script-outside-document
Related issue: #1929

original implementation

- code:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-before-interactive-script-outside-document.ts
- test:
https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-before-interactive-script-outside-document.test.ts
- doc:
https://nextjs.org/docs/messages/no-before-interactive-script-outside-document
@IWANABETHATGUY IWANABETHATGUY mentioned this issue Feb 20, 2024
Closed
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@camc314 @IWANABETHATGUY
feat: nextjs plugin (oxc-project#1948)
4aeb0a8 
oxc-project#1929 (comment)
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @IWANABETHATGUY
feat(linter): eslint-plugin-next: no-typos (oxc-project#1978)
0418070 
Part of: oxc-project#1929

Based on:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-typos.ts
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @camc314 @IWANABETHATGUY
feat(linter): eslint-plugin-next: no-head-element (oxc-project#2006)
6b8b58b 
Part of: oxc-project#1929

Based on:

- code: https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-head-element.ts
- test: https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-head-element.test.ts
- doc: https://nextjs.org/docs/messages/no-head-element

---------

Co-authored-by: Cameron Clark <cameron.clark@hey.com>
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @camc314 @IWANABETHATGUY
feat(linter): eslint-plugin-next: no-document-import-in-page (oxc-pro…
ccb9b67 
…ject#1997)

Part of: oxc-project#1929

Based on:
- https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-document-import-in-page.ts
-  https://nextjs.org/docs/messages/no-document-import-in-page

---------

Co-authored-by: Cameron <cameron.clark@hey.com>
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @IWANABETHATGUY
feat(linter): support eslint config in nextjs eslint (oxc-project#2107)
cc866e6 
related: oxc-project#1929

Support Next.js eslint config settings.
- [custom settings
](https://nextjs.org/docs/app/building-your-application/configuring/eslint#custom-settings)
- also handle Next.js eslint rule name mapping

these are need before implementing [this
rule](https://nextjs.org/docs/messages/no-html-link-for-pages)
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @IWANABETHATGUY
feat(linter): implement @next/next/no-unwanted-polyfillio (oxc-projec…
79b0f15 
…t#2197)

implement @next/next/no-unwanted-polyfillio
Related issue: oxc-project#1929

original implementation

- code:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-unwanted-polyfillio.ts
- test:
https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-unwanted-polyfillio.test.ts
- doc: https://nextjs.org/docs/messages/no-unwanted-polyfillio
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@kaykdm @IWANABETHATGUY
feat(linter): implement @next/next/no-before-interactive-script-outsi… (
acc7ba2 
oxc-project#2203)

…de-document

implement @next/next/no-before-interactive-script-outside-document
Related issue: oxc-project#1929

original implementation

- code:
https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-before-interactive-script-outside-document.ts
- test:
https://github.com/vercel/next.js/blob/canary/test/unit/eslint-plugin-next/no-before-interactive-script-outside-document.test.ts
- doc:
https://nextjs.org/docs/messages/no-before-interactive-script-outside-document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Boshen @camc314 @kaykdm