-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): implement @next/next/no-document-import-in-page #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaykdm
force-pushed
the
no-document-import-in-page
branch
from
January 11, 2024 13:10
b7722b2
to
21db74b
Compare
CodSpeed Performance ReportMerging #1997 will not alter performanceComparing Summary
|
kaykdm
force-pushed
the
no-document-import-in-page
branch
from
January 11, 2024 13:23
21db74b
to
7bbd3ac
Compare
IWANABETHATGUY
approved these changes
Jan 11, 2024
kaykdm
force-pushed
the
no-document-import-in-page
branch
from
January 12, 2024 12:44
a26fd1d
to
e1f355a
Compare
camc314
reviewed
Jan 12, 2024
crates/oxc_linter/src/rules/nextjs/no_document_import_in_page.rs
Outdated
Show resolved
Hide resolved
camc314
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
camc314
force-pushed
the
no-document-import-in-page
branch
from
January 13, 2024 17:46
87924e2
to
921438a
Compare
camc314
force-pushed
the
no-document-import-in-page
branch
from
January 13, 2024 17:49
921438a
to
3a905e1
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…ject#1997) Part of: oxc-project#1929 Based on: - https://github.com/vercel/next.js/blob/canary/packages/eslint-plugin-next/src/rules/no-document-import-in-page.ts - https://nextjs.org/docs/messages/no-document-import-in-page --------- Co-authored-by: Cameron <cameron.clark@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement @next/next/no-document-import-in-page
Related issue: #1929
original