Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vscode): add a option to control oxc lint timing #1659

Merged
merged 5 commits into from
Dec 13, 2023
Merged

feat(vscode): add a option to control oxc lint timing #1659

merged 5 commits into from
Dec 13, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Dec 12, 2023 •
edited
Loading

  1. Closed VSCode: don't underline if there's already an error #1653
  2. Now you use oxc-client.run to control the lint timing.
2023.12.12.23.39.16.webm

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 12, 2023 15:52
@IWANABETHATGUY IWANABETHATGUY changed the title feat: add a option vscode check timing feat: add a option to control oxc vscode extension lint timing Dec 12, 2023
@Dunqing Dunqing changed the title feat: add a option to control oxc vscode extension lint timing feat(vscode): add a option to control oxc lint timing Dec 13, 2023
@IWANABETHATGUY IWANABETHATGUY merged commit e63576d into oxc-project:main Dec 13, 2023
17 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/vscode-check-timing branch December 13, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Dunqing approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode: don't underline if there's already an error
2 participants
@IWANABETHATGUY @Dunqing