feat(linter): eslint-plugin-import no-named-as-default-member rule #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XantreDev
commented
Jan 11, 2024
•
XantreDev
commented
- Docs: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-named-as-default-member.md
- Code: https://github.com/import-js/eslint-plugin-import/blob/main/src/rules/no-named-as-default-member.js
- Tests: https://github.com/import-js/eslint-plugin-import/blob/main/tests/src/rules/no-named-as-default-member.js
CodSpeed Performance ReportMerging #1988 will not alter performanceComparing Summary
|
XantreDev
changed the title
XantreDev
changed the title
XantreDev
force-pushed
the
no-named-as-default-member
branch
2 times, most recently
from
708a1fa
to
b9c5eb0
Compare
mysteryven
reviewed
Jan 12, 2024
mysteryven
reviewed
Jan 12, 2024
crates/oxc_linter/src/rules/import/no_named_as_default_member.rs
Outdated
Show resolved
Hide resolved
XantreDev
force-pushed
the
no-named-as-default-member
branch
from
b9c5eb0
to
068e73d
Compare
mysteryven
approved these changes
Jan 13, 2024
|
Will you merge it?) |
Boshen
force-pushed
the
no-named-as-default-member
branch
from
095182f
to
84a3604
Compare
|
Thank you! |
Boshen
force-pushed
the
no-named-as-default-member
branch
from
84a3604
to
64de6e9
Compare
mysteryven
reviewed
Jan 16, 2024
| AstKind::VariableDeclarator(decl) => { | ||
| if let Some(Expression::MemberExpression(member_expr)) = &decl.init { | ||
| process_member_expr(member_expr); | ||
| return; |
There was a problem hiding this comment.
@XantreGodlike I know why, these return should be continue? 🙃 Change this will let the below case fail.
import baz from './named-exports';
{
const baz = {};
const a = baz.a;
}There was a problem hiding this comment.
Agree, will fix it in this week
mysteryven
pushed a commit
that referenced
this pull request
Jan 18, 2024
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…xc-project#1988) - Docs: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-named-as-default-member.md - Code: https://github.com/import-js/eslint-plugin-import/blob/main/src/rules/no-named-as-default-member.js - Tests: https://github.com/import-js/eslint-plugin-import/blob/main/tests/src/rules/no-named-as-default-member.js
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.