Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ban & Delete not correctly functioning on replies #1416

Closed
3 tasks done
alansley opened this issue Feb 9, 2024 · 0 comments
Closed
3 tasks done

[BUG] Ban & Delete not correctly functioning on replies #1416

alansley opened this issue Feb 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@alansley
Copy link

alansley commented Feb 9, 2024

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If you long press “Ban and delete“ on a users message which is a reply it bans the user, but fails to delete their messages.

Expected Behavior

If you long press “Ban and delete“ on a users message which is a reply it bans the user, but DOES delete their messages.

Steps To Reproduce

See above. I imagine this is in groups and/or communities.

Android Version

Android Any

Session Version

1.17.1 (3555)

Anything else?

This issue is tracked internally as: https://optf.atlassian.net/browse/SES-1156
@alansley alansley added the bug Something isn't working label Feb 9, 2024
AL-Session added a commit that referenced this issue Apr 2, 2024
@AL-Session @alansley @0x330a
SES-1156 - Ban and delete functionality fix (#1428)
a8a257a 
* WIP

* Investigation in progress

* End of day push

* WIP

* Fixes #1416

* Cleanup

* Added code to remove zombie messages caught in limbo during a ban & delete - still chock full o' debug while finding root cause

* Root cause debug WIP

* Push prior to cleanup

* Cleaned up for PR

* fix: mms delete, remove unnecessary values from sms

* Addressed PR feedback

* fix: fix unit tests

* Added '.run' folder with test setup

* Update README.md

Test commit for CI

* Re-added accidentally removed closing brace

---------

Co-authored-by: alansley <aclansley@gmail.com>
Co-authored-by: Al Lansley <alansley@users.noreply.github.com>
Co-authored-by: 0x330a <92654767+0x330a@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alansley