net: Use counters for event counters, count errors
#1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These essentially just represent "hey, here's the state of some hw register", so it's not super useful to generate counters for them --- we can save a bunch of bytes by just counting error variants.
hawkw
commented
Mar 21, 2024
hawkw
changed the title
counters for event counters, count errors
hawkw
added a commit
that referenced
this pull request
Mar 21, 2024
Depends on #1637 Now that the `vsc-err` types have `Count` implementations (as of #1637), I thought it might be worthwhile to add counters to the `monorail-server` ring bufs. This is especially nice because the one in `main` only has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.
cbiffle
reviewed
Mar 21, 2024
| @@ -25,7 +25,7 @@ request_reset = ["hiffy"] | |||
| name = "drv-stm32xx-sys" | |||
| features = ["h753"] | |||
| priority = 1 | |||
| max-sizes = {flash = 2048, ram = 1024} | |||
| max-sizes = {flash = 2048, ram = 2048} | |||
There was a problem hiding this comment.
I suspect app-mgmt.toml was broken, because it's not checked by CI
There was a problem hiding this comment.
We apparently don't actually build this task on CI, so it had, yet again, bitrotted. Since I had modified the Gimletlet net tasks, I wanted to make sure I hadn't made the net task too big for any of the Gimletlet apps, and had to fix this in order to verify that.
Happy to back out the change, because it is, admittedly, unrelated to the diff.
mkeeter
reviewed
Mar 21, 2024
mkeeter
approved these changes
Mar 21, 2024
hawkw
added a commit
that referenced
this pull request
Mar 21, 2024
Depends on #1637 Now that the `vsc-err` types have `Count` implementations (as of #1637), I thought it might be worthwhile to add counters to the `monorail-server` ring bufs. This is especially nice because the one in `main` only has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.
lzrd
pushed a commit
that referenced
this pull request
Mar 26, 2024
Currently, the `net` task has some hand-implemented event counters. Although these are simple and efficient, they don't match the format that `humility counters` will look for when finding counters in a dump, so they can't be queried using that command. Instead, they have to be inspected using a series of `humility readvar` commands. This branch, therefore, replaces the hand-written counters with the `counters` crate, allowing the `net` task's event counters to be understood by `humility counters`. Additionally, I've added counters to the ringbufs in some of the BSP modules (currently, only Gimletlet actually has ringbufs). For these, we skip counting the various status and control register ringbuf entries because they don't really seem to represent a countable event, just the state of a register, and skipping all of them lets us avoid several words of counters. Instead, we just count the number of error event variants.
lzrd
pushed a commit
that referenced
this pull request
Mar 26, 2024
Depends on #1637 Now that the `vsc-err` types have `Count` implementations (as of #1637), I thought it might be worthwhile to add counters to the `monorail-server` ring bufs. This is especially nice because the one in `main` only has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
nettask has some hand-implemented event counters.Although these are simple and efficient, they don't match the format
that
humility counterswill look for when finding counters in a dump,so they can't be queried using that command. Instead, they have to be
inspected using a series of
humility readvarcommands. This branch,therefore, replaces the hand-written counters with the
counterscrate,allowing the
nettask's event counters to be understood byhumility counters.Additionally, I've added counters to the ringbufs in some of the BSP
modules (currently, only Gimletlet actually has ringbufs). For these, we
skip counting the various status and control register ringbuf entries
because they don't really seem to represent a countable event, just the
state of a register, and skipping all of them lets us avoid several
words of counters. Instead, we just count the number of error event
variants.