monorail-server: Add ringbuf counters #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These essentially just represent "hey, here's the state of some hw register", so it's not super useful to generate counters for them --- we can save a bunch of bytes by just counting error variants.
Depends on #1637 Now that the `vsc-err` types have `Count` implementations (as of #1637), I thought it might be worthwhile to add counters to the `monorail-server` ring bufs. This is especially nice because the one in `main` only has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.
cbiffle
approved these changes
Mar 21, 2024
mkeeter
approved these changes
Mar 21, 2024
lzrd
pushed a commit
that referenced
this pull request
Mar 26, 2024
Depends on #1637 Now that the `vsc-err` types have `Count` implementations (as of #1637), I thought it might be worthwhile to add counters to the `monorail-server` ring bufs. This is especially nice because the one in `main` only has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1637
Now that the
vsc-errtypes haveCountimplementations (as of #1637), I thought it might be worthwhile to add counters to themonorail-serverring bufs. This is especially nice because the one inmainonly has two entries, and it seems worthwhile to be able to get a total count of errors that have been observed.