Remove /v1/disks/{disk}/metrics/{metric} endpoint

[karencfv]

With the introduction of OxQL this endpoint is no longer necessary. AFAIK The only place it was being used was the console, but it has since moved to using OxQL only.

We don't want our customers to start depending on this endpoint, or thinking that this endpoint follows a pattern that we will continue to use. We should remove it as soon as possible.

[karencfv]

Taking a look at this, it seems we should also remove /v1/system/metrics/{metric_name} and /v1/metrics/{metric_name} in favour of just keeping OxQL. Any objections from the UI side @david-crespo ? Any other metric related endpoints we might want to remove as well?

[david-crespo]

I need to make sure we’re not still using those in the console. I think we did switch them to OxQL.

[karencfv]

If you're still using them, do you mind if we tag them as experimental?

[karencfv]

cc @askfongjojo I wouldn't want to break your dashboards either 😅

[david-crespo]

We are still using the system and silo metrics endpoints in console on the utilization pages. Rather than marking experimental, I guess I'd prefer to convert them to OxQL and delete the endpoints, but we probably don't have time before this release. Let me look into it a bit.

https://github.com/oxidecomputer/console/blob/bcfd93888744ea4ec4bfb4323f8a153c6bf60e30/app/components/SystemMetric.tsx#L56-L57

https://github.com/oxidecomputer/console/blob/bcfd93888744ea4ec4bfb4323f8a153c6bf60e30/app/components/SystemMetric.tsx#L127-L144