Skip to content

API endpoints for listing IP Pools could use filter parameters #9147

@bnaecker

Description

@bnaecker

Here's the API today for listing IP Pools:

/// List IP pools
#[endpoint {
method = GET,
path = "/v1/system/ip-pools",
tags = ["system/ip-pools"],
}]
async fn ip_pool_list(
rqctx: RequestContext<Self::Context>,
query_params: Query<PaginatedByNameOrId>,
) -> Result<HttpResponseOk<ResultsPage<views::IpPool>>, HttpError>;

That's been fine because all the pools are pretty much fungible. But now we've added an IP version to the pools, and we're also making more distinctions such as whether a pool is delegated for internal Oxide use. We could add these as query parameters to these endpoints to avoid client-side filtering.

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiRelated to the API.good first issueIssues that are good for learning the codebasenexusRelated to nexus

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions