-
Notifications
You must be signed in to change notification settings - Fork 58
Open
Labels
apiRelated to the API.Related to the API.good first issueIssues that are good for learning the codebaseIssues that are good for learning the codebasenexusRelated to nexusRelated to nexus
Description
Here's the API today for listing IP Pools:
omicron/nexus/external-api/src/lib.rs
Lines 703 to 712 in 83f7f06
/// List IP pools | |
#[endpoint { | |
method = GET, | |
path = "/v1/system/ip-pools", | |
tags = ["system/ip-pools"], | |
}] | |
async fn ip_pool_list( | |
rqctx: RequestContext<Self::Context>, | |
query_params: Query<PaginatedByNameOrId>, | |
) -> Result<HttpResponseOk<ResultsPage<views::IpPool>>, HttpError>; |
That's been fine because all the pools are pretty much fungible. But now we've added an IP version to the pools, and we're also making more distinctions such as whether a pool is delegated for internal Oxide use. We could add these as query parameters to these endpoints to avoid client-side filtering.
Metadata
Metadata
Assignees
Labels
apiRelated to the API.Related to the API.good first issueIssues that are good for learning the codebaseIssues that are good for learning the codebasenexusRelated to nexusRelated to nexus