Refactor host OS CI scripts to allow running them locally #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Mar 15, 2023
| -F optever=0.21 \ | ||
| -P /work/gz/root \ | ||
| -B | ||
| # TODO: Consider importing zones here too? |
There was a problem hiding this comment.
A little redundant with the comment on line 66?
Comment on lines
+71
to
+78
| # Extract the trampoline global zone tarball into a tmp_gz directory | ||
| if ! tmp_gz=$(mktemp -d); then | ||
| exit 1 | ||
| fi | ||
| trap 'cd /; rm -rf "$tmp_gz"' EXIT | ||
|
|
||
| echo "Extracting trampoline gz packages into $tmp_gz" | ||
| ptime -m tar xvzf $TRAMPOLINE_PATH -C $tmp_gz |
There was a problem hiding this comment.
I suspect we'll want to package zone tarballs into the OS image at some point, which will probably end up changing this a little bit? IDK if we just want to pass an "already unpacked" directory to this script, or to make it a separate argument to pass files that should not be unpacked before getting thrown to the -P flag below.
|
@jgallagher is not back until Friday and said this was ok to merge with @smklein's approval. I'll leave post-hoc changes to him for now unless I get to them while playing around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
./tools/build-host-image.shscript which is extracted from the existing CI jobs to build host and trampoline images; those CI jobs now call this script (after doing some buildomat-specific setup).Marking this as a draft until it passes in CI to make sure I didn't break anything there.