[2/n] move instance_migrate and APIs used by tests/omdb from nexus-internal to nexus-lockstep #9037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
force-pushed
the
iliana/nexus-debug-continued
branch
2 times, most recently
from
55291f4 to
a68433d
Compare
davepacheco
reviewed
Sep 22, 2025
| mock.assert_calls_async(1).await; | ||
|
|
||
| // Deleting a subscription that doesn't exist should 404. | ||
| dbg!( |
There was a problem hiding this comment.
I'm surprised this got deleted instead of converted.
There was a problem hiding this comment.
I meant to write a note here. This test was calling an endpoint that does not exist on the internal APIs, only the external ones (DELETE /v1/alert-receivers/{receiver}/subscriptions/{subscription}). Because it does not exist, the API returns 404, and the test here "succeeds".
But now that I look at this again, I should be able to swap it for ctx.external_client and it should be testing the correct thing.
There was a problem hiding this comment.
Replacing it for the external client doesn't work as the delete endpoint returns 204 No Content even after the subscription was deleted.
iliana
force-pushed
the
iliana/nexus-debug-continued
branch
from
a68433d to
6255457
Compare
davepacheco
approved these changes
Sep 23, 2025
iliana
force-pushed
the
iliana/nexus-debug-continued
branch
from
6255457 to
8e3d4f5
Compare
iliana
added a commit
that referenced
this pull request
Sep 24, 2025
leftwo
pushed a commit
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8902. Stacked on #8983.