PlanningReport: Remove blueprint_id
#9052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
force-pushed
the
john/planning-report-no-blueprint-id
branch
from
5dbe31a to
35fda3c
Compare
davepacheco
approved these changes
Sep 19, 2025
jgallagher
force-pushed
the
john/planning-report-no-blueprint-id
branch
from
35fda3c to
8976641
Compare
jgallagher
force-pushed
the
john/planning-report-no-blueprint-id
branch
from
8976641 to
c38be9e
Compare
leftwo
pushed a commit
that referenced
this pull request
Sep 26, 2025
Planning reports are contained in `Blueprint`s, which have an ID. Prior to this PR we duplicated the containing blueprint's ID. This bit @davepacheco and me in a couple different (admittedly unusual) testing contexts where we were duplicating blueprints and making changes, not realizing we produced a new blueprint with a different ID but carrying a report that still pointed to the original blueprint's ID. The only thing we lose here is that the display output of the planning report can no longer say what blueprint it's for, but I think that's fine - all the places where we want to display a report, we already know the blueprint ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning reports are contained in
Blueprints, which have an ID. Prior to this PR we duplicated the containing blueprint's ID. This bit @davepacheco and me in a couple different (admittedly unusual) testing contexts where we were duplicating blueprints and making changes, not realizing we produced a new blueprint with a different ID but carrying a report that still pointed to the original blueprint's ID.The only thing we lose here is that the display output of the planning report can no longer say what blueprint it's for, but I think that's fine - all the places where we want to display a report, we already know the blueprint ID.