bump newtype-uuid to 1.3.1, use automatic replacement #9122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
commented
Sep 30, 2025
Comment on lines
+2320
to
+2325
| "MupdateUuid": { | ||
| "x-rust-type": { | ||
| "crate": "omicron-uuid-kinds", | ||
| "path": "omicron_uuid_kinds::MupdateUuid", | ||
| "version": "*" | ||
| }, |
There was a problem hiding this comment.
The types are much more reasonably named now as well (they use the same type alias as the one defined in uuid-kinds).
sunshowers
commented
Sep 30, 2025
Comment on lines
+29
to
+39
| settings = { | ||
| attrs = [#[derive(Diffable)]], | ||
| schemars08 = { | ||
| attrs = [#[cfg(feature = "schemars08")]], | ||
| rust_type = { | ||
| crate = "omicron-uuid-kinds", | ||
| version = "*", | ||
| path = "omicron_uuid_kinds", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is the x-rust-type magic.
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Oct 2, 2025
Comment on lines
-179
to
+186
| "TypedUuidForOmicronZoneKind": { | ||
| "OmicronZoneUuid": { | ||
| "type": "string", | ||
| "format": "uuid" | ||
| "format": "uuid", | ||
| "x-rust-type": { | ||
| "crate": "omicron-uuid-kinds", | ||
| "path": "omicron_uuid_kinds::OmicronZoneUuid", | ||
| "version": "*" | ||
| } |
There was a problem hiding this comment.
Worth noting that this change is identical on the wire, so there aren't any compatibility concerns.
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/bump-newtype-uuid-to-131-use-automatic-replacement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You never have to
replaceanyTypedUuidForFooKindtypes again! Also acts as a good test for wire-compatibility checking with drift.Also bumped all the versioned APIs to pick up the x-rust-type change, so that clients work with automatic replacement.