-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error on folder without any md file #14
Conversation
if a directory only has subdirectories, an error was thrown
Thanks, I'll update npm in a few minutes. |
@noelmace, I had to reverse this commit, because it failed a test. Could you please examine Could you please create a new failing test for your case and create a PR solving it. Thanks again. |
Hi ozum. If I understand correctly, you're talking about "should throw for missing README.md in Navbar", which was already failing before. I just ran
My bad 😓 I'm on it! |
if a directory only has subdirectories, an error was thrown. fix regression introduced by ozum#14
if a directory only has subdirectories, an error was thrown. fix regression introduced by ozum#14
done in #16 |
Failing test in order to reproduce the bug ozum#14 was initially trying to fix: if a directory only has subdirectories, an error is thrown. Fix ba73ee see ozum#16 (comment)
if a directory only has subdirectories, an error was thrown. fix regression introduced by ozum#14
if a directory only has subdirectories, a TypeError
(link.children[0] || "").split is not a function
was raised