Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on folder without any md file #16

Closed
wants to merge 2 commits into from

Conversation

nweldev
Copy link
Contributor

@nweldev nweldev commented Mar 31, 2020

if a directory only has subdirectories, an error was thrown.
fix regression introduced by #14 and add the associated test

@ozum
Copy link
Owner

ozum commented Apr 1, 2020

@noelmace. Your new test is passing without any code change.

image

I added your new test to latest version. Could you please check:

  1. Clone latest version to an empty directory.
  2. npm install
  3. npm test

Could you please first add a failing test with current code base, so I could understand what problem will be solved.

Many thanks for your time and efforts again.

Failing test in order to reproduce the bug ozum#14 was initially trying to
fix: if a directory only has subdirectories, an error is thrown.

Fix ba73ee
see ozum#16 (comment)
if a directory only has subdirectories, an error was thrown.
fix regression introduced by ozum#14
@nweldev
Copy link
Contributor Author

nweldev commented Apr 1, 2020

Thx @ozum for the feedback. So, in order to exactly reproduce the bug, I now changed the test in order to be as close as possible to my project. Yet, it doesn't fail.

Anyway, the related feature in my project isn't needed anymore, and I'm not sure anyone will need this fix. So, as I don't have a lot of time to continue working on this PR, I think we can drop it.

I'll open an issue with all the information you need to reproduce, in case anyone needs to fix it in the future.

@ozum
Copy link
Owner

ozum commented Apr 2, 2020

@noelmace, if you have any issue in the future, please reopen a case, I'll try to help. I cannot help this time, because I cannot produce the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants