Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static file server to http service #483

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Conversation

sandreae
Copy link
Member

@sandreae sandreae commented Aug 4, 2023

Use https://docs.rs/tower-http/latest/tower_http/services/struct.ServeDir.html# to add a static file server to the http service which serves content from $HOME/.local/share/aquadoggo/blobs by default.

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@sandreae sandreae changed the title Static file server Add static file server to http service Aug 4, 2023
@sandreae sandreae linked an issue Aug 8, 2023 that may be closed by this pull request
@sandreae sandreae changed the base branch from main to development August 8, 2023 15:15
@sandreae sandreae marked this pull request as ready for review August 8, 2023 15:15
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 96.42% and project coverage change: -0.01% ⚠️

Comparison is base (d5ba55d) 91.95% compared to head (2799ddd) 91.95%.
Report is 2 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #483      +/-   ##
===============================================
- Coverage        91.95%   91.95%   -0.01%     
===============================================
  Files              100      100              
  Lines            15914    15934      +20     
===============================================
+ Hits             14634    14652      +18     
- Misses            1280     1282       +2     
Files Changed Coverage Δ
aquadoggo/src/config.rs 47.91% <80.00%> (+4.73%) ⬆️
aquadoggo/src/graphql/mutations/publish.rs 98.68% <100.00%> (ø)
aquadoggo/src/http/context.rs 100.00% <100.00%> (ø)
aquadoggo/src/http/service.rs 98.80% <100.00%> (+0.21%) ⬆️
aquadoggo/src/test_utils/client.rs 76.47% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandreae sandreae merged commit 81cae95 into development Aug 9, 2023
8 checks passed
@adzialocha adzialocha deleted the static-file-server branch August 17, 2023 12:48
sandreae added a commit that referenced this pull request Aug 31, 2023
* Add static file server to `http` service

* Create blobs directory when it doesn't exist

* Export `BLOBS_DIR_NAME` const

* Update CHANGELOG

* Create temporary base_path dir when Configuration is ephemeral

* `fmt`

* Create all dirs in one step

* Change CHANGELOG
adzialocha added a commit that referenced this pull request Sep 8, 2023
* development:
  Make sure `/tmp` directory does not run out of scope before application ends (#557)
  Integrate `Bytes` value (#554)
  Stream blob data in chunks to files to not occupy too much memory (#551)
  Blobs directory configuration (#549)
  Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs
  Build a byte buffer over paginated pieces when assembling blobs (#547)
  HTTP routes to serve files with correct content type and etag headers (#544)
  Task for automatic garbage collection of unused documents and views (#500)
  Refactor tmp blob dir creation after rebase
  Fix after rebase
  "blob" materializer task (#493)
  Add static file server to `http` service (#483)
  Enable deletion of dangling `document_views` and related `document_view_fields` from db  (#491)
  BlobStore for retrieving raw blob data from the db (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static file HTTP server for blobs
1 participant