Build a byte buffer over paginated pieces when assembling blobs #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzialocha
changed the title
adzialocha
commented
Sep 4, 2023
adzialocha
commented
Sep 4, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## http-blob-router #547 +/- ##
=================================================
Coverage 92.50% 92.50%
=================================================
Files 105 105
Lines 17932 17939 +7
=================================================
+ Hits 16588 16595 +7
Misses 1344 1344
☔ View full report in Codecov by Sentry. |
Closed
sandreae
approved these changes
Sep 5, 2023
adzialocha
added a commit
that referenced
this pull request
Sep 6, 2023
* Build a byte buffer over paginated blob pieces * Add entry to CHANGELOG.md * Add doc string to constant * Mark panics as unreachable
adzialocha
added a commit
that referenced
this pull request
Sep 8, 2023
* development: Make sure `/tmp` directory does not run out of scope before application ends (#557) Integrate `Bytes` value (#554) Stream blob data in chunks to files to not occupy too much memory (#551) Blobs directory configuration (#549) Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs Build a byte buffer over paginated pieces when assembling blobs (#547) HTTP routes to serve files with correct content type and etag headers (#544) Task for automatic garbage collection of unused documents and views (#500) Refactor tmp blob dir creation after rebase Fix after rebase "blob" materializer task (#493) Add static file server to `http` service (#483) Enable deletion of dangling `document_views` and related `document_view_fields` from db (#491) BlobStore for retrieving raw blob data from the db (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the maximum limit of allowed blob pieces (for now, we might want to have it back with some sort of configuration interface). This touched upon the pagination logic used to iterate over all pieces, so I decided to just paginate through it in a classic manner, page by page.
On top this uses now the
BytesMutstruct to efficiently assemble the blob pieces. For the future we might want to do this instead #548 to avoid keeping very large blobs in memory.Closes: #546
📋 Checklist
CHANGELOG.md