Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blobs directory configuration #549

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Blobs directory configuration #549

merged 6 commits into from
Sep 6, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Sep 6, 2023

  • Introduce a blobs_base_path configuration value
  • It needs to be always set in aquadoggo (no Option anymore), think its good to have as much defined behaviour as possible in the crate (no magic creation of temporary folders etc.)
  • It can be set in aquadoggo_cli, when it is set to None a temporary folder will be given
  • aquadoggo_cli warns against using a temporary folder when database_url is set to a permament value (node will run out-of-sync with its own blobs data when it gets restarted)
  • Removed all places where folders are created automatically (for consistency, see my comment)

Closes: #542

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 96.36% and project coverage change: +0.01% 🎉

Comparison is base (7cbf5f5) 92.50% compared to head (c8f2e9b) 92.52%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #549      +/-   ##
===============================================
+ Coverage        92.50%   92.52%   +0.01%     
===============================================
  Files              105      105              
  Lines            17939    17931       -8     
===============================================
- Hits             16594    16590       -4     
+ Misses            1345     1341       -4     
Files Changed Coverage Δ
aquadoggo/src/db/stores/blob.rs 97.42% <ø> (ø)
aquadoggo/src/db/stores/entry.rs 99.40% <ø> (ø)
aquadoggo/src/db/stores/operation.rs 89.63% <ø> (ø)
aquadoggo/src/db/stores/schema.rs 98.37% <ø> (ø)
aquadoggo/src/db/types/entry.rs 90.00% <ø> (ø)
aquadoggo/src/db/types/operation.rs 88.00% <ø> (ø)
aquadoggo/src/graphql/queries/collection.rs 99.60% <ø> (ø)
...ggo/src/graphql/scalars/document_view_id_scalar.rs 78.57% <ø> (ø)
aquadoggo/src/materializer/tasks/dependency.rs 97.56% <ø> (ø)
...doggo/src/materializer/tasks/garbage_collection.rs 98.59% <ø> (ø)
... and 18 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
@adzialocha adzialocha marked this pull request as ready for review September 6, 2023 08:46
@sandreae sandreae merged commit 3140f68 into development Sep 6, 2023
10 checks passed
@adzialocha adzialocha deleted the blob_dir_config branch September 6, 2023 16:10
adzialocha added a commit that referenced this pull request Sep 6, 2023
* development:
  Blobs directory configuration (#549)
@adzialocha adzialocha linked an issue Sep 6, 2023 that may be closed by this pull request
adzialocha added a commit that referenced this pull request Sep 8, 2023
* development:
  Make sure `/tmp` directory does not run out of scope before application ends (#557)
  Integrate `Bytes` value (#554)
  Stream blob data in chunks to files to not occupy too much memory (#551)
  Blobs directory configuration (#549)
  Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs
  Build a byte buffer over paginated pieces when assembling blobs (#547)
  HTTP routes to serve files with correct content type and etag headers (#544)
  Task for automatic garbage collection of unused documents and views (#500)
  Refactor tmp blob dir creation after rebase
  Fix after rebase
  "blob" materializer task (#493)
  Add static file server to `http` service (#483)
  Enable deletion of dangling `document_views` and related `document_view_fields` from db  (#491)
  BlobStore for retrieving raw blob data from the db (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuring of blob directory path
2 participants