Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure /tmp directory does not run out of scope before application ends #557

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Sep 8, 2023

Moves TempDir instance into global scope to make sure it stays there for the whole applications lifetime.

Closes: #556

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

@adzialocha adzialocha marked this pull request as ready for review September 8, 2023 09:27
@adzialocha adzialocha linked an issue Sep 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9bbcd08) 92.46% compared to head (f8d6145) 92.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #557   +/-   ##
============================================
  Coverage        92.46%   92.46%           
============================================
  Files              106      106           
  Lines            18039    18039           
============================================
  Hits             16680    16680           
  Misses            1359     1359           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@adzialocha adzialocha merged commit 8791463 into development Sep 8, 2023
10 checks passed
@adzialocha adzialocha deleted the fix-temp-dir branch September 8, 2023 09:43
adzialocha added a commit that referenced this pull request Sep 8, 2023
* development:
  Make sure `/tmp` directory does not run out of scope before application ends (#557)
  Integrate `Bytes` value (#554)
  Stream blob data in chunks to files to not occupy too much memory (#551)
  Blobs directory configuration (#549)
  Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs
  Build a byte buffer over paginated pieces when assembling blobs (#547)
  HTTP routes to serve files with correct content type and etag headers (#544)
  Task for automatic garbage collection of unused documents and views (#500)
  Refactor tmp blob dir creation after rebase
  Fix after rebase
  "blob" materializer task (#493)
  Add static file server to `http` service (#483)
  Enable deletion of dangling `document_views` and related `document_view_fields` from db  (#491)
  BlobStore for retrieving raw blob data from the db (#484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/tmp folder for blobs does not exist when writing a file to it
1 participant