Enable deletion of dangling document_views and related document_view_fields from db
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #491 +/- ##
===============================================
+ Coverage 88.60% 92.07% +3.47%
===============================================
Files 42 100 +58
Lines 2202 16022 +13820
===============================================
+ Hits 1951 14752 +12801
- Misses 251 1270 +1019
☔ View full report in Codecov by Sentry. |
sandreae
changed the title
document_views rows and related document_view_fields from db document_views and related document_view_fields from db
sandreae
changed the title
document_views and related document_view_fields from db document_views and related document_view_fields from db
sandreae
changed the title
document_views and related document_view_fields from db document_views and related document_view_fields from db
sandreae
changed the title
document_views and related document_view_fields from db document_views and related document_view_fields from db
|
Need to make it work with postgres... |
Maybe drop PostgreSQL Support? 🙈 |
sandreae
added a commit
that referenced
this pull request
Aug 31, 2023
…ew_fields` from db (#491) * Add fk to document_view_fields with cascading DELETE * Introduce `prune_document_views` method to `DocumentStore` * Test for pruning document views * Test that pinned views don't get deleted * Update CHANGELOG * Clippy * Remove fk constraint on `operation_id` in `document_view_fields` table * Change table creation order in documents migration * Use IS NULL in SQL conditional * Don't use alias in SQL query
adzialocha
added a commit
that referenced
this pull request
Sep 8, 2023
* development: Make sure `/tmp` directory does not run out of scope before application ends (#557) Integrate `Bytes` value (#554) Stream blob data in chunks to files to not occupy too much memory (#551) Blobs directory configuration (#549) Use correct MAX_BLOB_PIECE_LENGTH from p2panda_rs Build a byte buffer over paginated pieces when assembling blobs (#547) HTTP routes to serve files with correct content type and etag headers (#544) Task for automatic garbage collection of unused documents and views (#500) Refactor tmp blob dir creation after rebase Fix after rebase "blob" materializer task (#493) Add static file server to `http` service (#483) Enable deletion of dangling `document_views` and related `document_view_fields` from db (#491) BlobStore for retrieving raw blob data from the db (#484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document_view_fieldsanddocument_viewsDocumentStorewhich takes aDocumentIdand deletes any unpinned+not current views📋 Checklist
CHANGELOG.md