Set --prefix only for format-coverage subcommand. #118
Conversation
| @@ -108,6 +108,9 @@ export function run( | |||
| `codeclimate.${i}.json` | |||
| ]; | |||
| if (codeClimateDebug === 'true') commands.push('--debug'); | |||
| if (!coveragePrefix && typeof coveragePrefix === 'string') { | |||
There was a problem hiding this comment.
@paambaati - As far as I can tell this logic is only going to append --prefix when coveragePrefix is "" (empty string). I'd make a PR to address/fix but I'm not quite sure what the goal here is. Are you trying to only add --prefix only when coveragePrefix was passed?
There was a problem hiding this comment.
Specifically, I'm seeing the following command being executed (note the --prefix without additional argument):
/home/runner/work/ember-cli/ember-cli/cc-reporter format-coverage coverage/lcov.info -t lcov -o codeclimate.0.json --prefix When the configuration is:
- name: Test && Report to Code Climate
uses: paambaati/codeclimate-action@v2.5.4
with:
coverageCommand: yarn test:cover
coverageLocations: "coverage/lcov.info:lcov"See the line here
There was a problem hiding this comment.
Are you trying to only add --prefix only when coveragePrefix was passed?
That is correct.
I'd make a PR to address/fix
Much appreciated, please and thank you.
There was a problem hiding this comment.
No problem! Here is what I was thinking #131 for the solution.
This PR fixes #117 and #109.