Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve obs_to_matrix with data.table #210

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from
Open

Improve obs_to_matrix with data.table #210

wants to merge 12 commits into from

Commits on Jun 27, 2018

  1. Configuration menu
    Copy the full SHA
    9acf16e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50b35d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. Merge pull request #191 from warrenmcg/patch_g2g

    Emergency patch to fix #190
    pimentel authored Jun 28, 2018
    Configuration menu
    Copy the full SHA
    24ca285 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Improve obs_to_matrix with data.table

    Replace reshape2::dcast with data.table::dcadt for speed gain and to avoid issue with long sample names causing vector return error in reshape2 but not data.table:
    
    Using reshape2:
    
    ```
     obs_counts <- dcast(obj$obs_norm, target_id ~ sample, value.var = value_name)
    Aggregation function missing: defaulting to length
    Error during wrapup: dims [product 868328] do not match the length of object [41674225]
    ```
    
    But no error using data.table.
    
    [`obj_norm`](https://s3.amazonaws.com/rech-ul/obj_norm.RDS?AWSAccessKeyId=AKIAI6SXE4VOIPIZJI6Q&Expires=1601162547&Signature=3lPIt6yZ2UPFhMioUwwRopzo8eM%3D) to reproduce:
    andrewrech authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    f94976b View commit details
    Browse the repository at this point in the history
  2. typo

    andrewrech authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    6a1e85d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Configuration menu
    Copy the full SHA
    ea5a390 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. Configuration menu
    Copy the full SHA
    395bcd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. importFrom utils head

    andrewrech authored Mar 16, 2019
    Configuration menu
    Copy the full SHA
    d05cd9b View commit details
    Browse the repository at this point in the history
  2. importFrom utils head

    andrewrech authored Mar 16, 2019
    Configuration menu
    Copy the full SHA
    ed95e72 View commit details
    Browse the repository at this point in the history
  3. utils::head

    For d05cd9b ed95e7
    andrewrech authored Mar 16, 2019
    Configuration menu
    Copy the full SHA
    e4341e6 View commit details
    Browse the repository at this point in the history
  4. convert plots.R reshape2 calls to data.table

    If `tabd_df` is not a data table, it is converted. Don't need `as.data.table`.
    andrewrech authored Mar 16, 2019
    Configuration menu
    Copy the full SHA
    5ca29dc View commit details
    Browse the repository at this point in the history
  5. Remove reshapre2 import

    andrewrech authored Mar 16, 2019
    Configuration menu
    Copy the full SHA
    b076a02 View commit details
    Browse the repository at this point in the history