-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve obs_to_matrix with data.table #210
Open
andrewrech
wants to merge
12
commits into
pachterlab:devel
Choose a base branch
from
andrewrech:master
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9acf16e - Browse repository at this point
Copy the full SHA 9acf16eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50b35d0 - Browse repository at this point
Copy the full SHA 50b35d0View commit details
Commits on Jun 28, 2018
-
Merge pull request #191 from warrenmcg/patch_g2g
Emergency patch to fix #190
Configuration menu - View commit details
-
Copy full SHA for 24ca285 - Browse repository at this point
Copy the full SHA 24ca285View commit details
Commits on Feb 4, 2019
-
Improve obs_to_matrix with data.table
Replace reshape2::dcast with data.table::dcadt for speed gain and to avoid issue with long sample names causing vector return error in reshape2 but not data.table: Using reshape2: ``` obs_counts <- dcast(obj$obs_norm, target_id ~ sample, value.var = value_name) Aggregation function missing: defaulting to length Error during wrapup: dims [product 868328] do not match the length of object [41674225] ``` But no error using data.table. [`obj_norm`](https://s3.amazonaws.com/rech-ul/obj_norm.RDS?AWSAccessKeyId=AKIAI6SXE4VOIPIZJI6Q&Expires=1601162547&Signature=3lPIt6yZ2UPFhMioUwwRopzo8eM%3D) to reproduce:
Configuration menu - View commit details
-
Copy full SHA for f94976b - Browse repository at this point
Copy the full SHA f94976bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1e85d - Browse repository at this point
Copy the full SHA 6a1e85dView commit details
Commits on Feb 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ea5a390 - Browse repository at this point
Copy the full SHA ea5a390View commit details
Commits on Feb 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 395bcd8 - Browse repository at this point
Copy the full SHA 395bcd8View commit details
Commits on Mar 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d05cd9b - Browse repository at this point
Copy the full SHA d05cd9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed95e72 - Browse repository at this point
Copy the full SHA ed95e72View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4341e6 - Browse repository at this point
Copy the full SHA e4341e6View commit details -
convert plots.R reshape2 calls to data.table
If `tabd_df` is not a data table, it is converted. Don't need `as.data.table`.
Configuration menu - View commit details
-
Copy full SHA for 5ca29dc - Browse repository at this point
Copy the full SHA 5ca29dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b076a02 - Browse repository at this point
Copy the full SHA b076a02View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.