Take into account multiple ways of redis persistence and ensure import is being done on the running UI pod. #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e existing data before the import. There might be ui pods that have failed. Ensure that only running one are used.
glaubinix
reviewed
Dec 12, 2024
| cp packagist_redis.rdb /var/openebs/local/$PV_NAME/dump.rdb | ||
| sudo rm -f /var/openebs/local/$PV_NAME/appendonly.aof | ||
| sudo rm -rf /var/openebs/local/$PV_NAME/appendonlydir | ||
| sudo cp packagist_redis.rdb /var/openebs/local/$PV_NAME/dump.rdb |
There was a problem hiding this comment.
If you need to cp this with sudo, can the Redis container still read the file or does this cause a permission issue?
There was a problem hiding this comment.
If we decide to remove sudo from the example, then would at least mention that they might require sudo
There was a problem hiding this comment.
All the existing files were owned by root. Also the Redis process is running as root, so cp with sudo should not cause any issues at all. I also didn't have any issues when testing this.
As the users might set up this differently, it might make more sense to take sudo out and mention that in a comment.
glaubinix
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Ticket: https://trello.com/c/w6Pj1IpF/4549-look-into-this-selfhosted-issues-while-migration-if-this-is-something-we-need-to-fix
Redis has multiple ways of persisting data on FS: https://redis.io/docs/latest/operate/oss_and_stack/management/persistence/
It can be a single .aof file or a combination of RDB+AOF. To ensure that we properly cleanup data for both cases, I left both commands in, but with the
-fflag to ensure that there are no errors if either path doesn't exist.NOTE: not sure about adding
sudo. It was needed for these commands in my case. Should we leave that in or rather remove it and the user must figure that out?Regarding the second issue in the Trello ticket, we can see that multiple pod names have been assigned to the
UI_PODvariable. I presume that other ones were just leftover pods of failed deployments. I added a filter to the command to ensure that only the running UI pod is assigned.