Add more details to Synchronizations page #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenrombauts
commented
Jan 27, 2025
Comment on lines
+31
to
+32
| * Code Credentials: GitHub App or GitHub API Token | ||
| * Webhooks: Code changes, releases, created repositories, team creation or member changes |
There was a problem hiding this comment.
I think this (Code Creds/Webhooks) is also relevant on this page, but kept it in place on the OAuth Integrations page too. So it's duplicated, but I think we should mention it on both locations. Thoughts?
There was a problem hiding this comment.
Makes sense to have it in both place but I would also keep the Synchronization: section on the integration page. This makes it easier to compare which features are available for which integration
glaubinix
reviewed
Jan 27, 2025
Comment on lines
+31
to
+32
| * Code Credentials: GitHub App or GitHub API Token | ||
| * Webhooks: Code changes, releases, created repositories, team creation or member changes |
There was a problem hiding this comment.
Makes sense to have it in both place but I would also keep the Synchronization: section on the integration page. This makes it easier to compare which features are available for which integration
naderman
requested changes
Jan 27, 2025
Co-authored-by: Stephan <glaubinix@users.noreply.github.com>
Co-authored-by: Nils Adermann <n.adermann@packagist.com>
naderman
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the information about synchronizations into a dedicated "Synchronizations" page, and out of the "OAuth integrations" page.