Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider default job timeout for VM image build babysits #2421

Conversation

lbarcziova
Copy link
Member

No description provided.

@lbarcziova lbarcziova requested a review from majamassarini May 7, 2024 10:57
Copy link
Contributor

Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is useful.
But do you think this will solve exceptions in prod? I read Compose with given id not found returned by the image builder service api, so I would have expected another kind of "code". Should I give it a look tomorrow?

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label May 7, 2024
@lbarcziova
Copy link
Member Author

But do you think this will solve exceptions in prod? I read Compose with given id not found returned by the image builder service api, so I would have expected another kind of "code". Should I give it a look tomorrow?

I checked which builds are causing these errors and there were only 2 which keep triggering this exception and they are both older than week, so I assume it could be really that those are already deleted from image builder or something like that.

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0827705811394670980662100a9c974c

✔️ pre-commit SUCCESS in 2m 30s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9c7b13d into packit:main May 7, 2024
4 checks passed
@lbarcziova lbarcziova deleted the babysit-timeout-vm-image-builds branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants