Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on the SRPM error #317

Merged

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Jan 9, 2020

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 9, 2020

Build failed.

@TomasTomecek
Copy link
Member

TomasTomecek commented Jan 9, 2020

Code LGTM, but tests need a bit of tinkering.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Jan 9, 2020

Basic tests should be fixed now.

This PR also fix this behaviour:

  • We are not failing the rpm-build statuses when the SRPM fails.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 9, 2020

Build failed.

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Jan 9, 2020

Let's merge and test on the Hello world!

@lachmanfrantisek lachmanfrantisek merged commit 33cbb76 into packit:master Jan 9, 2020
1 of 2 checks passed
@lachmanfrantisek lachmanfrantisek deleted the srpm-fail-behaviour branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants