Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on the SRPM error #317

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Comment on the SRPM error #317

merged 2 commits into from
Jan 9, 2020

Conversation

lachmanfrantisek
Copy link
Member

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@TomasTomecek
Copy link
Member

Code LGTM, but tests need a bit of tinkering.

@lachmanfrantisek
Comment on srpm error
4baf09a 
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek
Fail the rpm build statuses on srpm fail
1f03035 
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek
Copy link
Member Author

Basic tests should be fixed now.

This PR also fix this behaviour:

  • We are not failing the rpm-build statuses when the SRPM fails.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@lachmanfrantisek
Copy link
Member Author

Let's merge and test on the Hello world!

@lachmanfrantisek lachmanfrantisek merged commit 33cbb76 into packit:master Jan 9, 2020
@lachmanfrantisek lachmanfrantisek deleted the srpm-fail-behaviour branch January 9, 2020 15:39
@lachmanfrantisek lachmanfrantisek mentioned this pull request Jan 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lachmanfrantisek @TomasTomecek @jpopelka