Speed up CI by using pre-built tests image #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
force-pushed
the
speed-up-tests
branch
3 times, most recently
from
ec22972 to
0b2216e
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
0b2216e to
1e8a72e
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
1e8a72e to
ab05b0c
Compare
This comment has been minimized.
This comment has been minimized.
mfocko
reviewed
Feb 16, 2021
jpopelka
force-pushed
the
speed-up-tests
branch
from
ab05b0c to
44b465c
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
2 times, most recently
from
c240fba to
28f0d8c
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
84807e4 to
8d3d7aa
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
8d3d7aa to
bcc6580
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
bcc6580 to
d91f2b0
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
d91f2b0 to
eb18216
Compare
This comment has been minimized.
This comment has been minimized.
jpopelka
force-pushed
the
speed-up-tests
branch
from
eb18216 to
9b6ef9a
Compare
|
Build succeeded.
|
jpopelka
force-pushed
the
speed-up-tests
branch
from
9b6ef9a to
018bd7a
Compare
|
Build succeeded.
|
they have been commented out since where the history reaches
It doesn't seem to be used anywhere, we later copy responses into local_data_dir (tests_requre/openshift_integration)
it might not be needed since there's only one job, but it's confusing without it
Building worker:dev and then tests image from it is no advantage over building tests image from base. And it might lead to confusion when running tests locally and the worker:dev is outdated.
jpopelka
force-pushed
the
speed-up-tests
branch
from
018bd7a to
a3561c3
Compare
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have tests image in Quay.io which is re-built on a push to this repo.
When we run tests, we don't rebuild the image (as we used to), but use the
quay.io/packit/packit-service-testsand mount sources into its/src.Pros:
worker:dev&service:dev. It's actually 2 tests (1. tests with pre-recorded responses, 2. deployment test), but we run them together because spawning an Openshift cluster is such an expensive operation. If we split it, we could use pre-builtworker:dev&service:devfor the requre test, which would speed up it a lot. But we need to build them for the deployment test anyway, which would again take (with spawning a cluster for it) about 18min so all tests together would take the same time as now.Cons:
make test_imageandpodman push.