Skip to content

Packit service generated version make tar fail #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkonecny12 opened this issue Nov 16, 2020 · 6 comments · Fixed by #325
Closed

Packit service generated version make tar fail #192

jkonecny12 opened this issue Nov 16, 2020 · 6 comments · Fixed by #325
Assignees
Labels
kind/documentation Improvements to docs

Comments

@jkonecny12
Copy link

Hello,

I've found this issue when I was adding Packit support to one of our projects. Seems that tar has an issue with generated number for the package version from Packit.

https://prod.packit.dev/srpm-build/9864/logs

Message: Preparing of the upstream to the SRPM build failed: Command failed (rc=2, reason={"metadata":{},"status":"Failure","message":"command terminated with non-zero exit code: Error executing in Docker Container: 2","reason":"NonZeroExitCode","details":{"causes":[{"reason":"ExitCode","message":"2"}]}})
TEMP_DIR=$(mktemp --tmpdir -d initial-setup-localization-XXXXXXXXXX) && \
git clone --depth 1 -b master -- https://github.com/rhinstaller/initial-setup-l10n.git $TEMP_DIR && \
cp $TEMP_DIR/master/*.po ./po/ && \
rm -rf $TEMP_DIR
Cloning into '/tmp/initial-setup-localization-Ekg2Mdt3Yx'...
make[1]: Entering directory '/sandcastle/docker-io-usercont-sandcastle-prod-20201116-122742104903'
(GIT_DIR=.git git log > .changelog.tmp && mv .changelog.tmp ChangeLog; rm -f .changelog.tmp) || (touch ChangeLog; echo 'git directory not found: installing possibly empty changelog.' >&2)
make[1]: Leaving directory '/sandcastle/docker-io-usercont-sandcastle-prod-20201116-122742104903'
git archive --format=tar --prefix=initial-setup-0.3.84/ r0.3.84-1 > initial-setup-0.3.84.tar
mkdir initial-setup-0.3.84
cp -r po initial-setup-0.3.84
cp ChangeLog initial-setup-0.3.84/
tar -rf initial-setup-0.3.84.tar initial-setup-0.3.84
tar: value 1021440000 out of uid_t range 0..2097151
tar: Exiting with failure status due to previous errors
make: *** [Makefile:81: archive] Error 2

From my understanding tar archive couldn't be modified because of name but it's possible that I understand it wrong. It's not happening when the SRPM archive is created locally.

https://github.com/rhinstaller/initial-setup/blob/2ebb4ba4c2493d4a5fc8b61e9e872044ef383169/Makefile#L71

Not a priority issue for us. Instead of fixing this I'm changing how the project is packaged but it could be a valid issue for another project.

@TomasTomecek
Copy link
Member

tar: value 1021440000 out of uid_t range 0..2097151
tar: Exiting with failure status due to previous errors

This seems like a similar issue as with the archive generation in anaconda.

The problem is that openshift pod is running as a big UID (1021440000) which makes tar break.

I'd suggest pax tar format (tar -H pax): https://mgorny.pl/articles/portability-of-tar-features.html#user-and-group-information

@jkonecny12
Copy link
Author

I was thinking if it is not related. Thanks for that!

In that case, feel free to close this issue because as I mentioned in the description I'm switching the release process to setup.py instead.

@lachmanfrantisek
Copy link
Member

We agreed with @TomasTomecek that we should at least document this behaviour.

@lachmanfrantisek lachmanfrantisek transferred this issue from packit/packit Nov 24, 2020
@lachmanfrantisek lachmanfrantisek added the kind/documentation Improvements to docs label Nov 24, 2020
@stale
Copy link

stale bot commented Jan 23, 2021

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jan 23, 2021
@stale stale bot closed this as completed Feb 6, 2021
@mfocko mfocko reopened this Mar 3, 2021
@stale stale bot removed the stale Is the issue still valid? label Mar 3, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jun 2, 2021
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Jun 4, 2021
@stale
Copy link

stale bot commented Aug 4, 2021

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Aug 4, 2021
@TomasTomecek TomasTomecek removed the stale Is the issue still valid? label Aug 9, 2021
TomasTomecek added a commit to TomasTomecek/packit.dev that referenced this issue Aug 20, 2021
* created a more tree-like structure of the headings

* updated some of the content to be more clear

* added an info about the environment where actions are invoked and
  provided a resolution for the `tar` UID problem

Resolves: packit#192

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek self-assigned this Aug 20, 2021
softwarefactory-project-zuul bot added a commit that referenced this issue Aug 20, 2021
actions structure overhaul and resolve #192

created a more tree-like structure of the headings


updated some of the content to be more clear


added an info about the environment where actions are invoked and
provided a resolution for the tar UID problem


Resolves: #192

Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements to docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants