Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing wrapper to work with both symlinked and non-symlinked files #24

Merged
merged 1 commit into from
Aug 27, 2015

Conversation

mboudreau
Copy link

This will fix pact-foundation/pact-mock-service-npm#1 for both linux and osx. The bat file seems to already work with the Windows packaging.

Is it possible to repackage after this so that the latest can be used in node?

Cheers.

bethesque added a commit that referenced this pull request Aug 27, 2015
fixing wrapper to work with both symlinked and non-symlinked files
@bethesque bethesque merged commit b181114 into pact-foundation:master Aug 27, 2015
@bethesque
Copy link
Member

Thanks!

@mboudreau
Copy link
Author

Can you please do a new release? We could really use it here.

Thanks.

On Thu, Aug 27, 2015, 1:00 PM Beth Skurrie notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#24 (comment)
.

@bethesque
Copy link
Member

Already on it.

@bethesque
Copy link
Member

Windows is out, the other ones are coming https://www.npmjs.com/package/pact-mock-service-win32

@bethesque
Copy link
Member

All done.

@mboudreau
Copy link
Author

You are an absolute legend.

On Thu, Aug 27, 2015, 1:42 PM Beth Skurrie notifications@github.com wrote:

All done.


Reply to this email directly or view it on GitHub
#24 (comment)
.

@mboudreau
Copy link
Author

@bethesque Just tried it out. The Windows one is out and working, but the linux/osx one is still pointing to the last version (0.5.2-2). Looking at npmjs.org, it's the same thing there.

@mboudreau
Copy link
Author

@bethesque I could really use this for today. Don't want to rush you and I'd be happy to do it if I knew how.

@bethesque
Copy link
Member

It seems to have rebuilt the old version for some reason, trying a clean build again.

@mboudreau
Copy link
Author

thanks.

On Fri, Aug 28, 2015 at 9:15 AM Beth Skurrie notifications@github.com
wrote:

It seems to have rebuilt the old version for some reason, trying a clean
build again.


Reply to this email directly or view it on GitHub
#24 (comment)
.

@bethesque
Copy link
Member

Ah, something seems to be different in npm land. The commands that I used to publish yesterday are not working today...

dist $ npm publish pact-mock-service-linux-x86.tar.gz
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "publish" "pact-mock-service-linux-x86.tar.gz"
npm ERR! node v0.12.7
npm ERR! npm  v2.12.1
npm ERR! code E404

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/pact-mock-service-linux-x86.tar.gz
npm ERR! 404
npm ERR! 404 'pact-mock-service-linux-x86.tar.gz' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/bethanyskurrie/workspace/rea/biq/pact-mock-service-npm/dist/npm-debug.log

@bethesque
Copy link
Member

Ok, worked it out, the package names have changed (someone else did that for me) but the docs weren't updated, so I published using the old package names. Try again now.

@mboudreau
Copy link
Author

Cool, seems that a lot of them updated, however, there's still some package
names with the old version: https://www.npmjs.com/search?q=pact-mock-service

Like linux-x86, linux-x86_64 and osx. I think the names might of changed
though, to darwin from osx, x64 from x86_64 and ia32 from x86. If that's
the case, it might be good to mention this somewhere or maybe deprecate
those npm packages.

Thanks for all your help.

On Fri, Aug 28, 2015 at 9:34 AM Beth Skurrie notifications@github.com
wrote:

Ok, worked it out, the package names have changed (someone else did that
for me) but the docs weren't updated, so I published using the old package
names. Try again now.


Reply to this email directly or view it on GitHub
#24 (comment)
.

@bethesque
Copy link
Member

Yes, they did change, is there an npm way to deprecate things?

@mboudreau
Copy link
Author

You can use the deprecate or unpublish command from the CLI.

https://www.npmjs.com/package/deprecate
https://docs.npmjs.com/cli/unpublish

On Fri, Aug 28, 2015 at 10:00 AM Beth Skurrie notifications@github.com
wrote:

Yes, they did change, is there an npm way to deprecate things?


Reply to this email directly or view it on GitHub
#24 (comment)
.

@mboudreau
Copy link
Author

I've just tested it on all OS's, everything's working fine :)

On Fri, Aug 28, 2015 at 10:01 AM Michel Boudreau michelboudreau@gmail.com
wrote:

You can use the deprecate or unpublish command from the CLI.

https://www.npmjs.com/package/deprecate
https://docs.npmjs.com/cli/unpublish

On Fri, Aug 28, 2015 at 10:00 AM Beth Skurrie notifications@github.com
wrote:

Yes, they did change, is there an npm way to deprecate things?


Reply to this email directly or view it on GitHub
#24 (comment)
.

@bethesque
Copy link
Member

Have finally released this! Apologies it took so long.

@mboudreau
Copy link
Author

Is there a way to document the release process so that we don't have a
single person that has to do it?

On Wed, Oct 7, 2015, 9:19 PM Beth Skurrie notifications@github.com wrote:

Have finally released this! Apologies it took so long.


Reply to this email directly or view it on GitHub
#24 (comment)
.

@bethesque
Copy link
Member

For the npm project, it's in CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_modules/.bin/pact-mock-service does not work
2 participants