Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add docker images for Python 3.9-3.11 for testing purposes #335

Merged
merged 4 commits into from
Apr 2, 2023

Conversation

sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented Mar 17, 2023

This pull request introduces the ability to build Docker images for Python versions 3.9, 3.10, and 3.11. Additionally, it unifies the existing images to ensure consistency and maintainability. The documentation has been proofread for clarity and accuracy, and the build instructions have been updated to reflect these new changes.

Also, this change makes it easier to build for Python 3.7/3.8.
@sergeyklay sergeyklay changed the title feat(test): add docker images for Python 3.9 and 3.10 for testing purposes feat(test): add docker images for Python 3.9-3.11 for testing purposes Apr 2, 2023
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
sergeyklay and others added 3 commits April 2, 2023 22:18
Co-authored-by: Mike Geeves <71873349+mikegeeves@users.noreply.github.com>
Co-authored-by: Mike Geeves <71873349+mikegeeves@users.noreply.github.com>
Co-authored-by: Mike Geeves <71873349+mikegeeves@users.noreply.github.com>
Copy link
Contributor

@mikegeeves mikegeeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
I think we can do more re the single Dockerfile approach, but maybe it makes sense to add in as a next step

@sergeyklay sergeyklay merged commit e99e7fb into pact-foundation:master Apr 2, 2023
@sergeyklay sergeyklay deleted the feature/docker-run branch April 2, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants