chore(ffi): deprecate pactffi_with_binary_file
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pactffi_with_binary_file` is functionally replaced by the combination of `pactffi_with_binary_body` and `pactffi_with_matching_ruless`. These two functions should be preferred over this one. Furthermore, this function's naming (especially when compared to `pactffi_with_binary_body`) which might suggest it merely sets the body by reading a specific binary file. Signed-off-by: JP-Ellis <josh@jpellis.me>
rholshausen
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pactffi_with_binary_fileis functionally replaced by the combination ofpactffi_with_binary_bodyandpactffi_with_matching_ruless. These two functions should be preferred over this one.Furthermore, this function's naming (especially when compared to
pactffi_with_binary_body) which might suggest it merely sets the body by reading a specific binary file.