Invalid JVM testcase? Incorrect spec?

[richard-reece]

I'm trying to validate a new verifier against the test corpus.

The JVM testcase in the version-2 branch "testcases/response/body/array with regex matcher xml.json" appears to have an invalid JSON path spec according to the pact specification, as it uses "$.body.myDates[*].date['#text']" (the ['#text'] is not valid, according to the spec).

Which is correct, the spec or the test case?

[uglyog]

#text is the representation of an XML text node. Because of the hash character, it has to be represented in the [''] form in the path expression, as $.body.myDates[*].date.#text would not be valid.

[richard-reece]

So I sense you're leaning towards "the test is correct"? :-)

[richard-reece]

Similarly the version-2 test case request/body/matches with regex with bracket notation.json also has a string element expression, which again isn't mentioned as valid in the spec "All path elements are separated by periods (.), except array indices which use square brackets ([])." If non-index array expressions are allowed, the spec should say so.

[uglyog]

The path expressions are based on JSON path, which provides a bracket notation which is needed to escape the attribute names. The spec needs to be updated to include it.

[richard-reece]

Yep, thanks! :-)