Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for text/plain responses #8

Closed
bethesque opened this issue Jun 23, 2014 · 9 comments
Closed

Add examples for text/plain responses #8

bethesque opened this issue Jun 23, 2014 · 9 comments

Comments

@bethesque
Copy link
Member

No description provided.

@neilcampbell
Copy link
Member

Added new PR to add these test cases #20

@bethesque
Copy link
Member Author

Cool, they need a content type header.

@neilcampbell
Copy link
Member

PR updated. Does that also mean we should be adding the application/json header for the rest of the test case?

@bethesque
Copy link
Member Author

The rest of which test case?

@neilcampbell
Copy link
Member

All of the body ones that contain a json response body.

@bethesque
Copy link
Member Author

Yes, they probably should.

@neilcampbell
Copy link
Member

Did you want me to do it as part of this PR #20 or create a new one?

@bethesque
Copy link
Member Author

Separate, it's nothing to do with #20.

@uglyog
Copy link
Member

uglyog commented Jul 19, 2016

Closing this, I'm going to add notes on the rules of determining the content type.

@uglyog uglyog closed this as completed Jul 19, 2016
NickOppersdorff pushed a commit to NickOppersdorff/pact-specification that referenced this issue May 16, 2024
@mdcruz
Merge pull request pact-foundation#8 from mdcruz/dependabot/npm_and_y…
c015b9e 
…arn/y18n-4.0.1

Bump y18n from 4.0.0 to 4.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bethesque @uglyog @neilcampbell