Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class names completion when started typing any string name #64

Closed
wants to merge 1 commit into from

Conversation

mkusher
Copy link
Member

@mkusher mkusher commented Sep 9, 2016

Adds #59

|| (
parent::canHandle($project, $context)
&& ($context->isString() || $context->isEmpty())
&& strlen($postfix) > 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$postfix doesn't exist

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that is a problem

@golaod
Copy link

golaod commented Sep 9, 2016

You have a bug in your code.

@mkusher mkusher force-pushed the feature/class-completion-by-name branch from 5b957fa to fcf8e79 Compare September 10, 2016 13:28
@mkusher
Copy link
Member Author

mkusher commented Sep 10, 2016

@golaod I've fixed the bug and also I've added new test case for classes

@mkusher mkusher added this to the 0.3 milestone Sep 10, 2016
@halftan
Copy link
Contributor

halftan commented Dec 29, 2016

move to #82

@mkusher mkusher closed this Dec 29, 2016
@mkusher mkusher deleted the feature/class-completion-by-name branch December 29, 2016 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants