Declare react and react-native as peer dependencies #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package configuration to address dependency management best practices by removing React dependencies from devDependencies and relying on peer dependencies instead. This change helps eliminate false vulnerability alerts while maintaining compatibility with consuming applications.
- Version bump from 1.2.1 to 1.3.0 to reflect the dependency management changes
- Removal of
reactandreact-nativefrom devDependencies to rely on peer dependencies - Minor formatting improvement to the keywords array
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thespacemanatee
previously approved these changes
Sep 15, 2025
quekshuy
force-pushed
the
quekshuy/move-react-and-react-native-dependencies/1
branch
from
bca8278 to
883eb5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request makes a minor update to the
package.jsonfile, primarily updating the package version and making small formatting changes to the keywords section. There are no significant code or dependency changes.Version update:
1.2.1to1.3.0.Metadata and formatting:
keywordsarray to a single-line format.reactandreact-nativefromdevDependencies.Why
Declaring our own (dev)dependencies leads to many alerts for vulnerabilities in the package, that are patched in the main application that consumes the package anyway.