Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the new Google analytics code was reverted? #48

Closed
ignatk opened this issue Aug 25, 2018 · 6 comments
Closed

Why the new Google analytics code was reverted? #48

ignatk opened this issue Aug 25, 2018 · 6 comments

Comments

@ignatk
Copy link

ignatk commented Aug 25, 2018

The is no description in d2f951c as to why the gtag Google analytics code was reverted. Could you, please, clarify?
@benbalter
Copy link

@sjparkinson Looks like this was part of #43. Can you explain your reasoning?

@sjparkinson
Copy link

#44

@sjparkinson
Copy link

It was separated out into a new PR.

@sjparkinson
Copy link

I think we've hit a bad merge by doing #43 after #44. Reverting the revert should correct it.

I should have cleaned up #43 better after the suggestion to split the work, my mistake.

@benbalter
Copy link

@secumod if you'd like to submit a pull request to add it back, I'd be glad to merge it.

ignatk added a commit to ignatk/cayman that referenced this issue Aug 28, 2018
@ignatk
Upgrade from analytics.js to gtag.js.
5edede8 
This reverts commit d2f951c.
Seems the commit was reverted by mistake.
Closes pages-themes#48
@ignatk ignatk mentioned this issue Aug 28, 2018
Merged
@ignatk
Copy link
Author

ignatk commented Aug 28, 2018 •
edited

BTW, was a1733bb reverted by error as well?

@YDX-2147483647 YDX-2147483647 mentioned this issue Jan 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjparkinson @benbalter @ignatk