chore: [#177560087] Changed pick psp screen UI #2954

andrea-favaro · 2021-04-01T08:42:01Z

Short description

Integrated new Figma UI in PickPspScreen and added business name if there is an error on loading provider image

How to test

Move into PickPspScreen and check if it is similar to the new UI version in Figma

pagopa-github-bot · 2021-04-01T08:42:36Z

Affected stories

⚙️ #177560087: Migliorare aspetto pagina scelta PSP

Generated by 🚫 dangerJS against 2f73650

codecov · 2021-04-01T08:45:19Z

Codecov Report

Merging #2954 (2f73650) into master (6885b58) will increase coverage by 0.09%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #2954      +/-   ##
==========================================
+ Coverage   59.20%   59.30%   +0.09%     
==========================================
  Files         915      916       +1     
  Lines       25184    25208      +24     
  Branches     4668     4674       +6     
==========================================
+ Hits        14911    14950      +39     
+ Misses      10174    10158      -16     
- Partials       99      100       +1

Impacted Files	Coverage Δ
ts/screens/wallet/payment/PickPspScreen.tsx	`82.14% <65.21%> (+27.42%)`	⬆️
ts/components/wallet/payment/PspComponent.tsx	`100.00% <100.00%> (ø)`
ts/utils/stringBuilder.ts	`100.00% <0.00%> (+7.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6885b58...2f73650. Read the comment docs.

thisisjp · 2021-04-01T10:39:30Z

@andrea-favaro could you please attach a video showing the performed changes?

andrea-favaro · 2021-04-01T13:57:50Z

@andrea-favaro could you please attach a video showing the performed changes?

@thisisjp Video

debiff · 2021-04-02T12:55:32Z

ts/components/core/typography/Label.tsx

@@ -6,7 +6,7 @@ import { typographyFactory } from "./Factory";

 type AllowedColors = Extract<
  IOColorType,
-  "blue" | "bluegrey" | "white" | "red"
+  "blue" | "bluegrey" | "white" | "red" | "bluegreyDark"


These components are mapped with the ones in the UI catalogue.

If is not strictly required is better avoid to modify it.

For example in this case you can use the H4 component that has the same font-size and already have the bluegreyDark color

debiff · 2021-04-02T13:00:38Z

ts/components/core/typography/LabelSmall.tsx

@@ -9,7 +9,7 @@ type AllowedColors = Extract<
  // tslint:disable-next-line:max-union-size
  "blue" | "bluegrey" | "red" | "white"
 >;
-type AllowedWeight = Extract<IOFontWeight, "Bold">;
+type AllowedWeight = Extract<IOFontWeight, "Bold" | "Regular">;


In this case you can use H5 component instead.

debiff · 2021-04-02T13:22:54Z

ts/screens/wallet/payment/PickPspScreen.tsx

        contextualHelpMarkdown={contextualHelpMarkdown}
        faqCategories={["payment"]}
      >
-        <Content noPadded={true}>
-          <View spacer={true} />
+        <Content noPadded>


What do you think about use a SafeAreaView component instead?

Suggested change

<Content noPadded>

<SafeAreaView style={IOStyles.flex}>

debiff · 2021-04-02T13:25:41Z

ts/screens/wallet/payment/PickPspScreen.tsx

          />
        </Content>
+        <FooterWithButtons type="SingleButton" leftButton={backButtonProps} />


There is already a function that returns the props you set in backButtonProps. Can you use it?

Suggested change

<FooterWithButtons type="SingleButton" leftButton={backButtonProps} />

<FooterWithButtons

type="SingleButton"

leftButton={cancelButtonProps(

this.props.navigateBack,

I18n.t("global.buttons.back")

)}

/>

debiff · 2021-04-02T13:58:48Z

ts/screens/wallet/payment/PickPspScreen.tsx

-            size={ICON_SIZE}
-            color={customVariables.contentPrimaryBackground}
-          />
+          {!this.state.hasImageLoadingError ? (


There is a problem in the way you check if an image has an error.

The state is the same for all the items you generate, so if 1 of the images is not reachable also all the others doesn't show the image.

What about using the useImageResize utils:

Suggested change

{!this.state.hasImageLoadingError ? (

{useImageResize(BASE_IMG_W, BASE_IMG_H, item.logoPSP).fold(

<Body>{item.businessName}</Body>,

size => {

const imageStyle: StyleProp<ImageStyle> = {

width: size[0],

height: size[1],

resizeMode: "contain"

};

return (

<Image

style={imageStyle}

resizeMode="contain"

source={{ uri: item.logoPSP }}

/>

);

}

)}

Of course being a hook you should convert the in component in a function component.

…k to show psp logo

debiff · 2021-04-12T11:06:10Z

@thisisjp If the psp upload fails for any reason (eg 500 - server error) is this the expected behavior?

Screen.Recording.2021-04-12.at.13.05.25.mov

If not, what can we show? This happens also if for any reason the /psps/all returns a void array.

debiff · 2021-04-07T11:13:27Z

ts/screens/wallet/payment/PickPspScreen.tsx

          />
-        </Content>
+        </SafeAreaView>
+        <FooterWithButtons


Can you move the FooterWithButtons inside the SafeAreaView please?
It has no effect otherwise:

debiff · 2021-04-12T10:52:58Z

ts/screens/wallet/payment/PickPspScreen.tsx

-    paddingVertical: 16,
-    paddingHorizontal: customVariables.contentPadding,
-    flexDirection: "column"
-  },
  line1: {


Can be a better name?

Suggested change

line1: {

header: {

debiff · 2021-04-12T11:17:06Z

ts/components/PspComponent.tsx

+      testID={`psp-${psp.id}`}
+    >
+      <View style={styles.line1}>
+        {psp.logoPSP && imageStyle ? (


Seems this check is duplicated. If psp.logoPSP is undefined useImageResize is left so imageStyle already has this information.

Suggested change

{psp.logoPSP && imageStyle ? (

{imageStyle ? (

Do you agree?

debiff · 2021-04-12T11:20:16Z

ts/components/PspComponent.tsx

@@ -0,0 +1,78 @@
+import React, { FC } from "react";


What do you think to about moving this component in ts/components/wallet/payment/PspComponent.tsx

thisisjp · 2021-04-12T14:05:52Z

@debiff I guess since we haven't introduced any new logic in this issue, we've never faced this "empty state" scenario before, right? Can we use the well-known "umbrella" screen with the retry button? 😄 ☔

debiff · 2021-04-13T13:07:39Z

@debiff I guess since we haven't introduced any new logic in this issue, we've never faced this "empty state" scenario before, right? Can we use the well-known "umbrella" screen with the retry button? 😄 ☔

@thisisjp No problem for me! What do you think about uniforming also the loading behaviour? At the moment, as you can see in the video, there is semi-transparent overlay while in many other situation we used a screen like this:

…a/io-app into 177560087-chore-choose-psp

…ls (#5133) Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.6 to 1.26.18. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>1.26.18</h2> <ul> <li>Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. (GHSA-g4mx-q9vg-27p4)</li> </ul> <h2>1.26.17</h2> <ul> <li>Added the <code>Cookie</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>. (GHSA-v845-jxx5-vc9f)</li> </ul> <h2>1.26.16</h2> <ul> <li>Fixed thread-safety issue where accessing a <code>PoolManager</code> with many distinct origins would cause connection pools to be closed while requests are in progress (<a href="https://redirect.github.com/urllib3/urllib3/issues/2954">#2954</a>)</li> </ul> <h2>1.26.15</h2> <ul> <li>Fix socket timeout value when HTTPConnection is reused (<a href="https://redirect.github.com/urllib3/urllib3/issues/2645">urllib3/urllib3#2645</a>)</li> <li>Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (<a href="https://redirect.github.com/urllib3/urllib3/issues/2899">urllib3/urllib3#2899</a>)</li> <li>Fix IDNA handling of 'x80' byte (<a href="https://redirect.github.com/urllib3/urllib3/issues/2901">urllib3/urllib3#2901</a>)</li> </ul> <h2>1.26.14</h2> <ul> <li>Fixed parsing of port 0 (zero) returning None, instead of 0 (<a href="https://redirect.github.com/urllib3/urllib3/issues/2850">#2850</a>)</li> <li>Removed deprecated <code>HTTPResponse.getheaders()</code> calls in <code>urllib3.contrib</code> module.</li> </ul> <h2>1.26.13</h2> <ul> <li>Deprecated the <code>HTTPResponse.getheaders()</code> and <code>HTTPResponse.getheader()</code> methods.</li> <li>Fixed an issue where parsing a URL with leading zeroes in the port would be rejected even when the port number after removing the zeroes was valid.</li> <li>Fixed a deprecation warning when using cryptography v39.0.0.</li> <li>Removed the <code><4</code> in the <code>Requires-Python</code> packaging metadata field.</li> </ul> <h2>1.26.12</h2> <ul> <li>Deprecated the <code>urllib3[secure]</code> extra and the <code>urllib3.contrib.pyopenssl</code> module. Both will be removed in v2.x. See this <a href="https://redirect.github.com/urllib3/urllib3/issues/2680">GitHub issue</a> for justification and info on how to migrate.</li> </ul> <h2>1.26.11</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p> <p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <ul> <li>Fixed an issue where reading more than 2 GiB in a call to HTTPResponse.read would raise an OverflowError on Python 3.9 and earlier.</li> </ul> <h2>1.26.10</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p> <p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <p>:closed_lock_with_key: <strong>This is the first release to be signed with Sigstore!</strong> You can verify the distributables using the <code>.sig</code> and <code>.crt</code> files included on this release.</p> <ul> <li>Removed support for Python 3.5</li> <li>Fixed an issue where a <code>ProxyError</code> recommending configuring the proxy as HTTP instead of HTTPS could appear even when an HTTPS proxy wasn't configured.</li> </ul> <h2>1.26.9</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>1.26.18 (2023-10-17)</h1> <ul> <li>Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.</li> </ul> <h1>1.26.17 (2023-10-02)</h1> <ul> <li>Added the <code>Cookie</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>. (<code>[#3139](urllib3/urllib3#3139) <https://github.com/urllib3/urllib3/pull/3139></code>_)</li> </ul> <h1>1.26.16 (2023-05-23)</h1> <ul> <li>Fixed thread-safety issue where accessing a <code>PoolManager</code> with many distinct origins would cause connection pools to be closed while requests are in progress (<code>[#2954](urllib3/urllib3#2954) <https://github.com/urllib3/urllib3/pull/2954></code>_)</li> </ul> <h1>1.26.15 (2023-03-10)</h1> <ul> <li>Fix socket timeout value when <code>HTTPConnection</code> is reused (<code>[#2645](urllib3/urllib3#2645) <https://github.com/urllib3/urllib3/issues/2645></code>__)</li> <li>Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (<code>[#2899](urllib3/urllib3#2899) <https://github.com/urllib3/urllib3/issues/2899></code>__)</li> <li>Fix IDNA handling of '\x80' byte (<code>[#2901](urllib3/urllib3#2901) <https://github.com/urllib3/urllib3/issues/2901></code>__)</li> </ul> <h1>1.26.14 (2023-01-11)</h1> <ul> <li>Fixed parsing of port 0 (zero) returning None, instead of 0. (<code>[#2850](urllib3/urllib3#2850) <https://github.com/urllib3/urllib3/issues/2850></code>__)</li> <li>Removed deprecated getheaders() calls in contrib module. Fixed the type hint of <code>PoolKey.key_retries</code> by adding <code>bool</code> to the union. (<code>[#2865](urllib3/urllib3#2865) <https://github.com/urllib3/urllib3/issues/2865></code>__)</li> </ul> <h1>1.26.13 (2022-11-23)</h1> <ul> <li>Deprecated the <code>HTTPResponse.getheaders()</code> and <code>HTTPResponse.getheader()</code> methods.</li> <li>Fixed an issue where parsing a URL with leading zeroes in the port would be rejected even when the port number after removing the zeroes was valid.</li> <li>Fixed a deprecation warning when using cryptography v39.0.0.</li> <li>Removed the <code><4</code> in the <code>Requires-Python</code> packaging metadata field.</li> </ul> <h1>1.26.12 (2022-08-22)</h1> <ul> <li>Deprecated the <code>urllib3[secure]</code> extra and the <code>urllib3.contrib.pyopenssl</code> module. Both will be removed in v2.x. See this <code>GitHub issue <https://github.com/urllib3/urllib3/issues/2680></code>_ for justification and info on how to migrate.</li> </ul> <h1>1.26.11 (2022-07-25)</h1> <ul> <li>Fixed an issue where reading more than 2 GiB in a call to <code>HTTPResponse.read</code> would</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/9c2c2307dd1d6af504e09aac0326d86ee3597a0b"><code>9c2c230</code></a> Release 1.26.18 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3159">#3159</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b594c5ceaca38e1ac215f916538fb128e3526a36"><code>b594c5c</code></a> Merge pull request from GHSA-g4mx-q9vg-27p4</li> <li><a href="https://github.com/urllib3/urllib3/commit/944f0eb134485f41bc531be52de12ba5a37bca73"><code>944f0eb</code></a> [1.26] Use vendored six in urllib3.contrib.securetransport</li> <li><a href="https://github.com/urllib3/urllib3/commit/c9016bf464751a02b7e46f8b86504f47d4238784"><code>c9016bf</code></a> Release 1.26.17</li> <li><a href="https://github.com/urllib3/urllib3/commit/01220354d389cd05474713f8c982d05c9b17aafb"><code>0122035</code></a> Backport GHSA-v845-jxx5-vc9f (<a href="https://redirect.github.com/urllib3/urllib3/issues/3139">#3139</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/e63989f97d206e839ab9170c8a76e3e097cc60e8"><code>e63989f</code></a> Fix installing <code>brotli</code> extra on Python 2.7</li> <li><a href="https://github.com/urllib3/urllib3/commit/2e7a24d08713a0131f0b3c7197889466d645cc49"><code>2e7a24d</code></a> [1.26] Configure OS for RTD to fix building docs</li> <li><a href="https://github.com/urllib3/urllib3/commit/57181d6ea910ac7cb2ff83345d9e5e0eb816a0d0"><code>57181d6</code></a> [1.26] Improve error message when calling urllib3.request() (<a href="https://redirect.github.com/urllib3/urllib3/issues/3058">#3058</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/3c0148048a523325819377b23fc67f8d46afc3aa"><code>3c01480</code></a> [1.26] Run coverage even with failed jobs</li> <li><a href="https://github.com/urllib3/urllib3/commit/d94029b7e2193ff47b627906a70e06377a09aae8"><code>d94029b</code></a> Release 1.26.16</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/1.26.6...1.26.18">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=1.26.6&new-version=1.26.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pagopa/io-app/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cristiano Tofani <cri.tofani@gmail.com>

…e_button_exists (#5132) Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.6 to 1.26.18. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>1.26.18</h2> <ul> <li>Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. (GHSA-g4mx-q9vg-27p4)</li> </ul> <h2>1.26.17</h2> <ul> <li>Added the <code>Cookie</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>. (GHSA-v845-jxx5-vc9f)</li> </ul> <h2>1.26.16</h2> <ul> <li>Fixed thread-safety issue where accessing a <code>PoolManager</code> with many distinct origins would cause connection pools to be closed while requests are in progress (<a href="https://redirect.github.com/urllib3/urllib3/issues/2954">#2954</a>)</li> </ul> <h2>1.26.15</h2> <ul> <li>Fix socket timeout value when HTTPConnection is reused (<a href="https://redirect.github.com/urllib3/urllib3/issues/2645">urllib3/urllib3#2645</a>)</li> <li>Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (<a href="https://redirect.github.com/urllib3/urllib3/issues/2899">urllib3/urllib3#2899</a>)</li> <li>Fix IDNA handling of 'x80' byte (<a href="https://redirect.github.com/urllib3/urllib3/issues/2901">urllib3/urllib3#2901</a>)</li> </ul> <h2>1.26.14</h2> <ul> <li>Fixed parsing of port 0 (zero) returning None, instead of 0 (<a href="https://redirect.github.com/urllib3/urllib3/issues/2850">#2850</a>)</li> <li>Removed deprecated <code>HTTPResponse.getheaders()</code> calls in <code>urllib3.contrib</code> module.</li> </ul> <h2>1.26.13</h2> <ul> <li>Deprecated the <code>HTTPResponse.getheaders()</code> and <code>HTTPResponse.getheader()</code> methods.</li> <li>Fixed an issue where parsing a URL with leading zeroes in the port would be rejected even when the port number after removing the zeroes was valid.</li> <li>Fixed a deprecation warning when using cryptography v39.0.0.</li> <li>Removed the <code><4</code> in the <code>Requires-Python</code> packaging metadata field.</li> </ul> <h2>1.26.12</h2> <ul> <li>Deprecated the <code>urllib3[secure]</code> extra and the <code>urllib3.contrib.pyopenssl</code> module. Both will be removed in v2.x. See this <a href="https://redirect.github.com/urllib3/urllib3/issues/2680">GitHub issue</a> for justification and info on how to migrate.</li> </ul> <h2>1.26.11</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p> <p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <ul> <li>Fixed an issue where reading more than 2 GiB in a call to HTTPResponse.read would raise an OverflowError on Python 3.9 and earlier.</li> </ul> <h2>1.26.10</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p> <p>:warning: <strong>urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <p>:closed_lock_with_key: <strong>This is the first release to be signed with Sigstore!</strong> You can verify the distributables using the <code>.sig</code> and <code>.crt</code> files included on this release.</p> <ul> <li>Removed support for Python 3.5</li> <li>Fixed an issue where a <code>ProxyError</code> recommending configuring the proxy as HTTP instead of HTTPS could appear even when an HTTPS proxy wasn't configured.</li> </ul> <h2>1.26.9</h2> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a>.</strong></p>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>1.26.18 (2023-10-17)</h1> <ul> <li>Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.</li> </ul> <h1>1.26.17 (2023-10-02)</h1> <ul> <li>Added the <code>Cookie</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>. (<code>[#3139](urllib3/urllib3#3139) <https://github.com/urllib3/urllib3/pull/3139></code>_)</li> </ul> <h1>1.26.16 (2023-05-23)</h1> <ul> <li>Fixed thread-safety issue where accessing a <code>PoolManager</code> with many distinct origins would cause connection pools to be closed while requests are in progress (<code>[#2954](urllib3/urllib3#2954) <https://github.com/urllib3/urllib3/pull/2954></code>_)</li> </ul> <h1>1.26.15 (2023-03-10)</h1> <ul> <li>Fix socket timeout value when <code>HTTPConnection</code> is reused (<code>[#2645](urllib3/urllib3#2645) <https://github.com/urllib3/urllib3/issues/2645></code>__)</li> <li>Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (<code>[#2899](urllib3/urllib3#2899) <https://github.com/urllib3/urllib3/issues/2899></code>__)</li> <li>Fix IDNA handling of '\x80' byte (<code>[#2901](urllib3/urllib3#2901) <https://github.com/urllib3/urllib3/issues/2901></code>__)</li> </ul> <h1>1.26.14 (2023-01-11)</h1> <ul> <li>Fixed parsing of port 0 (zero) returning None, instead of 0. (<code>[#2850](urllib3/urllib3#2850) <https://github.com/urllib3/urllib3/issues/2850></code>__)</li> <li>Removed deprecated getheaders() calls in contrib module. Fixed the type hint of <code>PoolKey.key_retries</code> by adding <code>bool</code> to the union. (<code>[#2865](urllib3/urllib3#2865) <https://github.com/urllib3/urllib3/issues/2865></code>__)</li> </ul> <h1>1.26.13 (2022-11-23)</h1> <ul> <li>Deprecated the <code>HTTPResponse.getheaders()</code> and <code>HTTPResponse.getheader()</code> methods.</li> <li>Fixed an issue where parsing a URL with leading zeroes in the port would be rejected even when the port number after removing the zeroes was valid.</li> <li>Fixed a deprecation warning when using cryptography v39.0.0.</li> <li>Removed the <code><4</code> in the <code>Requires-Python</code> packaging metadata field.</li> </ul> <h1>1.26.12 (2022-08-22)</h1> <ul> <li>Deprecated the <code>urllib3[secure]</code> extra and the <code>urllib3.contrib.pyopenssl</code> module. Both will be removed in v2.x. See this <code>GitHub issue <https://github.com/urllib3/urllib3/issues/2680></code>_ for justification and info on how to migrate.</li> </ul> <h1>1.26.11 (2022-07-25)</h1> <ul> <li>Fixed an issue where reading more than 2 GiB in a call to <code>HTTPResponse.read</code> would</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/9c2c2307dd1d6af504e09aac0326d86ee3597a0b"><code>9c2c230</code></a> Release 1.26.18 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3159">#3159</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b594c5ceaca38e1ac215f916538fb128e3526a36"><code>b594c5c</code></a> Merge pull request from GHSA-g4mx-q9vg-27p4</li> <li><a href="https://github.com/urllib3/urllib3/commit/944f0eb134485f41bc531be52de12ba5a37bca73"><code>944f0eb</code></a> [1.26] Use vendored six in urllib3.contrib.securetransport</li> <li><a href="https://github.com/urllib3/urllib3/commit/c9016bf464751a02b7e46f8b86504f47d4238784"><code>c9016bf</code></a> Release 1.26.17</li> <li><a href="https://github.com/urllib3/urllib3/commit/01220354d389cd05474713f8c982d05c9b17aafb"><code>0122035</code></a> Backport GHSA-v845-jxx5-vc9f (<a href="https://redirect.github.com/urllib3/urllib3/issues/3139">#3139</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/e63989f97d206e839ab9170c8a76e3e097cc60e8"><code>e63989f</code></a> Fix installing <code>brotli</code> extra on Python 2.7</li> <li><a href="https://github.com/urllib3/urllib3/commit/2e7a24d08713a0131f0b3c7197889466d645cc49"><code>2e7a24d</code></a> [1.26] Configure OS for RTD to fix building docs</li> <li><a href="https://github.com/urllib3/urllib3/commit/57181d6ea910ac7cb2ff83345d9e5e0eb816a0d0"><code>57181d6</code></a> [1.26] Improve error message when calling urllib3.request() (<a href="https://redirect.github.com/urllib3/urllib3/issues/3058">#3058</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/3c0148048a523325819377b23fc67f8d46afc3aa"><code>3c01480</code></a> [1.26] Run coverage even with failed jobs</li> <li><a href="https://github.com/urllib3/urllib3/commit/d94029b7e2193ff47b627906a70e06377a09aae8"><code>d94029b</code></a> Release 1.26.16</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/1.26.6...1.26.18">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=1.26.6&new-version=1.26.18)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pagopa/io-app/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[#177560087] Changed pick psp screen UI

3920580

andrea-favaro requested review from CrisTofani, debiff, fabriziofff, thisisjp and Undermaken as code owners April 1, 2021 08:42

pagopa-github-bot changed the title ~~[#177560087] Changed pick psp screen UI~~ chore: [#177560087] Changed pick psp screen UI Apr 1, 2021

[#177560087] fixed eslint error

523e5f9

Andrea Favarò and others added 2 commits April 2, 2021 09:45

[#177560087] Changed serviceName with businessName

65b5064

Merge branch 'master' into 177560087-chore-choose-psp

71ffe8c

debiff suggested changes Apr 2, 2021

View reviewed changes

Andrea Favarò added 2 commits April 2, 2021 18:14

[#177560087] Using correct core components and using image resize hoo…

c091a76

…k to show psp logo

[#177560087] Solved eslint error

a283d05

andrea-favaro marked this pull request as draft April 8, 2021 08:21

[#177560087] added testing and refactored components to match tests

2bdd3d9

andrea-favaro marked this pull request as ready for review April 8, 2021 09:58

andrea-favaro requested a review from debiff April 8, 2021 09:59

Merge branch 'master' into 177560087-chore-choose-psp

75fbf2d

debiff suggested changes Apr 12, 2021

View reviewed changes

debiff and others added 3 commits April 13, 2021 15:07

Merge branch 'master' into 177560087-chore-choose-psp

f5f0384

[#177560087] Code and tree folder improvements

3b36c83

Merge branch '177560087-chore-choose-psp' of https://github.com/pagop…

427d032

…a/io-app into 177560087-chore-choose-psp

andrea-favaro requested a review from debiff April 13, 2021 13:50

Andrea Favarò and others added 4 commits April 19, 2021 17:25

[#177560087] Added loading error component

25cb7e2

[#177560087] Solved eslint error

b8217e1

[#177560087] Added translations

b57e37d

Merge branch 'master' into 177560087-chore-choose-psp

2f73650

debiff approved these changes Apr 21, 2021

View reviewed changes

debiff merged commit dfe7310 into master Apr 21, 2021

debiff deleted the 177560087-chore-choose-psp branch April 21, 2021 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: [#177560087] Changed pick psp screen UI #2954

chore: [#177560087] Changed pick psp screen UI #2954

andrea-favaro commented Apr 1, 2021 •

edited

Loading

pagopa-github-bot commented Apr 1, 2021 •

edited

Loading

codecov bot commented Apr 1, 2021 •

edited

Loading

thisisjp commented Apr 1, 2021

andrea-favaro commented Apr 1, 2021

debiff Apr 2, 2021

debiff Apr 2, 2021

debiff Apr 2, 2021

debiff Apr 2, 2021

debiff Apr 2, 2021

debiff commented Apr 12, 2021 •

edited

Loading

debiff Apr 7, 2021

debiff Apr 12, 2021

debiff Apr 12, 2021

debiff Apr 12, 2021

thisisjp commented Apr 12, 2021

debiff commented Apr 13, 2021

-          {!this.state.hasImageLoadingError ? (
+         {useImageResize(BASE_IMG_W, BASE_IMG_H, item.logoPSP).fold(
+          <Body>{item.businessName}</Body>,
+          size => {
+            const imageStyle: StyleProp<ImageStyle> = {
+              width: size[0],
+              height: size[1],
+              resizeMode: "contain"
+            };
+            return (
+              <Image
+                style={imageStyle}
+                resizeMode="contain"
+                source={{ uri: item.logoPSP }}
+              />
+            );
+          }
+        )}

chore: [#177560087] Changed pick psp screen UI #2954

chore: [#177560087] Changed pick psp screen UI #2954

Conversation

andrea-favaro commented Apr 1, 2021 • edited Loading

Short description

How to test

pagopa-github-bot commented Apr 1, 2021 • edited Loading

Affected stories

codecov bot commented Apr 1, 2021 • edited Loading

Codecov Report

thisisjp commented Apr 1, 2021

andrea-favaro commented Apr 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

debiff commented Apr 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thisisjp commented Apr 12, 2021

debiff commented Apr 13, 2021

andrea-favaro commented Apr 1, 2021 •

edited

Loading

pagopa-github-bot commented Apr 1, 2021 •

edited

Loading

codecov bot commented Apr 1, 2021 •

edited

Loading

debiff commented Apr 12, 2021 •

edited

Loading